CRDB retry backoff #1195
Merged
CRDB retry backoff #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecordell
force-pushed
the
crdb-retry-backoff
branch
2 times, most recently
from
73e6f3b
to
044c634
Compare
github-actions
bot
added
area/CLI
github-actions
bot
removed
area/dependencies
ecordell
force-pushed
the
crdb-retry-backoff
branch
from
7fe36cf
to
d823914
Compare
vroldanbet
reviewed
Apr 10, 2023
| @@ -61,10 +64,17 @@ func executeWithResets(ctx context.Context, fn innerFunc, maxRetries uint8) (err | |||
| for retries = 0; retries <= maxRetries; retries++ { | |||
| err = fn(ctx) | |||
| if resettable(ctx, err) { | |||
| log.Ctx(ctx).Warn().Err(err).Msg("retrying resetteable database error") | |||
| after := retry.BackoffExponentialWithJitter(100*time.Millisecond, 0.5)(uint(retries)) | |||
There was a problem hiding this comment.
Once this lands, I'd suggest opening an issue to make this parameterizable.
ecordell
force-pushed
the
crdb-retry-backoff
branch
from
d823914
to
b8778f7
Compare
vroldanbet
approved these changes
Apr 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds exponential backoff to tx retries for CRDB.
This is recommended by CRDB docs, but isn't implemented in
cockroach-go(which we don't use). In theory this should help under heavy contention, but I would like to test it some more before merging.