spanner: close row iterators when done #1212
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of places where we build an iterator but then don't use the
Do
consumer.Any time we don't use the
Do
consumer, we need to explicitly close the iterator to avoid leaking a session. In all of the places where we weren't already usingDo
, we were only reading one row anyway, so I just switched toDo
for those cases too.This should fix #1196, but we'll want to some testing to confirm.
From Spanner Docs: