Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverts caveat covering index for postgres datastore #1222

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Mar 22, 2023

partially reverts #1118

we observed no performance gains while load-testing the new index, but it did impact write throughput
significantly

@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Mar 22, 2023
@vroldanbet vroldanbet changed the title reverts caveat covering index reverts caveat covering index for postgres datastore Mar 22, 2023
we observed no performance gains while load-testing
the new index, but it did impact write throughput
significantly
@vroldanbet vroldanbet marked this pull request as ready for review March 22, 2023 20:32
@vroldanbet vroldanbet requested a review from a team as a code owner March 22, 2023 20:32
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet merged commit 791b442 into main Mar 22, 2023
@vroldanbet vroldanbet deleted the revert-covering-index branch March 22, 2023 20:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants