Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check the defaults for hashring construction #1270

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Check the defaults for hashring construction #1270

merged 1 commit into from
Apr 17, 2023

Conversation

josephschorr
Copy link
Member

Ensures that no invalid values are given

@josephschorr josephschorr requested a review from a team as a code owner April 17, 2023 21:16
@github-actions github-actions bot added the area/CLI Affects the command line label Apr 17, 2023
ecordell
ecordell previously approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@ecordell ecordell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr
Check the defaults for hashring construction
96499a8 
Ensures that no invalid values are given
@josephschorr josephschorr merged commit 5ae5f30 into authzed:main Apr 17, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2023
@josephschorr josephschorr deleted the hashring-defaults branch April 17, 2023 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ecordell ecordell ecordell approved these changes

Assignees
No one assigned
Labels
area/CLI Affects the command line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@josephschorr @ecordell