Properly handle context cancelation in LookupResources processing #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/api v1
This fixed a deadlock where if the context was canceled from above the LR call, the checking resource stream could rarely end up deadlocked when trying to queue more items for publishing
josephschorr
force-pushed
the
lr-context-cancel
branch
from
49f445c
to
7e4d897
Compare
vroldanbet
reviewed
Jun 12, 2023
|
Updated |
vroldanbet
previously approved these changes
Jun 12, 2023
josephschorr
force-pushed
the
lr-context-cancel
branch
from
011d1f5
to
91cf0f1
Compare
vroldanbet
approved these changes
Jun 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.