Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pgx leak in 5.4.x #1430

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Fix pgx leak in 5.4.x #1430

merged 2 commits into from
Jul 11, 2023

Conversation

vroldanbet
Copy link
Contributor

this vendors commit 2bf5a614018d35b5db4259b5541497ab35175882
which includes fix to pgx memory leak.

See jackc/pgx#1676

Also found an instance Rows.Close() wasn't being called

@vroldanbet vroldanbet requested a review from a team as a code owner July 11, 2023 16:52
@github-actions github-actions bot added area/datastore Affects the storage system area/dependencies Affects dependencies labels Jul 11, 2023
@vroldanbet
fixes memory leak in pgx
64937cd 
this vendors commit 2bf5a614018d35b5db4259b5541497ab35175882
which includes fix to pgx memory leak.

See jackc/pgx#1676
@vroldanbet
add missing Rows.close()
6247d70
@vroldanbet vroldanbet self-assigned this Jul 11, 2023
josephschorr
josephschorr approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Let's make sure to unpin once pgx contains the fix in a released version

@vroldanbet vroldanbet added this pull request to the merge queue Jul 11, 2023
Merged via the queue into main with commit 45af672 Jul 11, 2023
25 checks passed
@vroldanbet vroldanbet deleted the fix-pgx-leak branch July 11, 2023 17:15
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees

@vroldanbet vroldanbet

Labels
area/datastore Affects the storage system area/dependencies Affects dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vroldanbet @josephschorr