fix TestReadBadZookieFlake #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
occasionally, the timetamps in the changelog can be behind now-gcwindow by 5-7ms. bumping the gc window up a bit stabilizes the test Signed-off-by: Evan Cordell <cordell.evan@gmail.com>
github-actions
bot
added
area/api v0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flake is caused by GC pauses. I can't produce a failure with
GOGC=off.When the test gets unlucky w.r.t GC, the timestamps in the changelog can be behind
now-gcwindowby 5-7ms. Bumping the GC window up a bit stabilizes the test so thatnow-gcwindowis less than the changelog timestamps even if there are GC pauses.Prior to this change, I could get 1-5 failures / 1k runs. After the change, I can't reproduce the flake.
Fixes #101