CRDB: adds missing observability for Watch API #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds a few helper methods to postgres/common so instrument queries issued in CockroachDB datastore when doing Watch API. Logs where missing and made it difficult to troubleshoot Watch API calls.
vroldanbet
force-pushed
the
observable-watch-queries-crdb
branch
from
4970181
to
3102df4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a few helper methods to postgres/common
so instrument queries issued in CockroachDB
datastore when doing Watch API. Logs
where missing and made it difficult to troubleshoot Watch API calls.