Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add goreleaser configuration to push Windows package to Chocolatey #1879

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

josephschorr
Copy link
Member

No description provided.

@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Apr 26, 2024
jzelinskie
jzelinskie previously approved these changes May 1, 2024
@jzelinskie
Copy link
Member

jzelinskie commented May 1, 2024

Looks like goreleaser needs a bit more:

⨯ release failed after 2m29s               error=chocolatey requires at least one windows archive

@jzelinskie
Copy link
Member

Looks like adding

    # Can be used to change the archive formats for specific GOOSs.
    # Most common use case is to archive as zip on Windows.
    format_overrides:
      - # Which GOOS to override the format for.
        goos: windows

        # The format to use for the given GOOS.
        #
        # Valid options are `tar.gz`, `tgz`, `tar.xz`, `txz`, tar`, `gz`, `zip`, `binary`, and `none`.
        format: zip

should fix it per goreleaser/goreleaser#4450

.goreleaser.yml Outdated
license_url: "https://github.com/authzed/spicedb/blob/main/LICENSE"
require_license_acceptance: false
project_source_url: "https://github.com/authzed/spicedb"
docs_url: "https://docs.authzed.com"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.goreleaser.yml Outdated
api_key: "{{ .Env.CHOCOLATEY_API_KEY }}"
source_repo: "https://push.chocolatey.org/"
skip_publish: false
goamd64: "v1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove any properties that are the default for better signal/noise ratio:

  • goamd64
  • skip_publish
  • require_license_acceptance

jzelinskie
jzelinskie previously approved these changes Jul 1, 2024
@josephschorr josephschorr marked this pull request as ready for review July 3, 2024 17:52
@@ -1,6 +1,6 @@
---
name: "Security"
on: # yamllint disable-line rule:truthy
on: # yamllint disable-line rule:truthy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once again haha

@@ -45,4 +76,6 @@ jobs:
HOMEBREW_TAP_GITHUB_TOKEN: "${{ secrets.HOMEBREW_TAP_GITHUB_TOKEN }}"
GORELEASER_KEY: "${{ secrets.GORELEASER_KEY }}"
GEMFURY_PUSH_TOKEN: "${{ secrets.GEMFURY_PUSH_TOKEN }}"
- name: "Release snap"
env:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this an accident? this "step" has nothing to run?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's super odd.... I'll revert; I wonder if I accidentally hit tab on Copilot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants