fix the postgres prom GC metrics to respect enable prom option #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jake Moshenko <jacob.moshenko@gmail.com>
jzelinskie
reviewed
Oct 15, 2021
| err = prometheus.Register(gcTransactionsClearedGauge) | ||
| if err != nil { | ||
| return nil, fmt.Errorf(errUnableToInstantiate, err) | ||
| } |
There was a problem hiding this comment.
Do we want to make this a runtime error or just use promauto?
There was a problem hiding this comment.
I don't know... it's not clear to me when prom registering can fail just based on the API. It's going to bubble up to a fatal in our binary anyway but probably with better wrapping.
There was a problem hiding this comment.
Yeah, I think this is fine, given it'll bubble up almost immediately if an error is returned here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jake Moshenko jacob.moshenko@gmail.com