Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin work on LookupSubjects #736

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Conversation

josephschorr
Copy link
Member

@josephschorr josephschorr commented Aug 5, 2022

This PR adds the dispatching support for LookupSubjects.

NOTE: This does not yet implement the actual API, nor does it change the dispatch for expand in any way. An open item is whether we want to change expand to share the same implementation as this code.

First step for #261
Part of #207

@github-actions github-actions bot added area/api v1 Affects the v1 API area/datastore Affects the storage system area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Aug 5, 2022
@josephschorr josephschorr force-pushed the lookup-subjects branch 3 times, most recently from 3c139cf to 8224900 Compare August 5, 2022 23:39
@josephschorr josephschorr force-pushed the lookup-subjects branch 2 times, most recently from cd142fa to 5166721 Compare August 6, 2022 00:12
@josephschorr josephschorr marked this pull request as ready for review August 15, 2022 17:14
@josephschorr josephschorr requested review from vroldanbet and a team as code owners August 15, 2022 17:14
internal/datastore/common/sql_test.go Outdated Show resolved Hide resolved
internal/datastore/common/sql.go Outdated Show resolved Hide resolved
internal/datastore/common/sql.go Outdated Show resolved Hide resolved
internal/datastore/common/sql.go Show resolved Hide resolved
internal/datastore/common/sql.go Outdated Show resolved Hide resolved
internal/dispatch/graph/graph.go Outdated Show resolved Hide resolved
internal/dispatch/graph/graph.go Outdated Show resolved Hide resolved
internal/dispatch/remote/cluster.go Outdated Show resolved Hide resolved
internal/dispatch/remote/cluster.go Outdated Show resolved Hide resolved
internal/graph/lookupsubjects.go Outdated Show resolved Hide resolved
…tiple resource IDs

This is in prep for the dispatch for lookup subjects
@josephschorr
Copy link
Member Author

Updated

@josephschorr josephschorr force-pushed the lookup-subjects branch 3 times, most recently from 752bb30 to 916a7dc Compare August 19, 2022 18:58
@josephschorr
Copy link
Member Author

Updated

@josephschorr josephschorr merged commit 684c254 into authzed:main Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2022
@josephschorr josephschorr deleted the lookup-subjects branch August 23, 2022 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api v1 Affects the v1 API area/datastore Affects the storage system area/dispatch Affects dispatching of requests area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants