v1: add the read method #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedt
force-pushed
the
v1-read
branch
2 times, most recently
from
db9e207
to
c21875c
Compare
| return &v1.PermissionsService_ServiceDesc | ||
| } | ||
|
|
||
| func NewPermissionsServer(ds datastore.Datastore, nsm namespace.Manager) v1.PermissionsServiceServer { |
| tupleUserset := tuple.User.GetUserset() | ||
|
|
||
| subjectRelation := "" | ||
| if tupleUserset.Relation != datastore.Ellipsis { |
There was a problem hiding this comment.
We're not returning ... anymore either?
There was a problem hiding this comment.
Nope. I don't think we should.
jzelinskie
requested changes
Sep 14, 2021
cmd/spicedb/root.go
Outdated
| grpcprom.UnaryServerInterceptor, | ||
| ) | ||
|
|
||
| grpcServer, err := cobrautil.GrpcServerFromFlags(cmd, middleware) | ||
| stream_middlware := grpc.ChainStreamInterceptor( |
There was a problem hiding this comment.
there's no snake case in go -- some people use it in package names, but even that's dubious
we need to fix the linter so stuff like this gets caught.
|
|
||
| atRevision := consistency.RevisionFromContext(ctx) | ||
| if atRevision == nil { | ||
| return status.Error(codes.Internal, "consistency middleware did not inject revision") |
| return status.Errorf(codes.Canceled, "request canceled: %s", err) | ||
|
|
||
| case errors.As(err, &graph.ErrAlwaysFail{}): | ||
| fallthrough |
There was a problem hiding this comment.
Is this supposed to be fallthrough? into OutOfRange? probably not
ecordell
reviewed
Sep 15, 2021
| return &v1.PermissionsService_ServiceDesc | ||
| } | ||
|
|
||
| func NewPermissionsServer(ds datastore.Datastore, nsm namespace.Manager) v1.PermissionsServiceServer { |
There was a problem hiding this comment.
maybe this should be private, and RegisterPermissionsServer should build the server too. then you're forced to register with middleware (unless you're a test in this package)
| } | ||
|
|
||
| err := resp.Send(&v1.ReadRelationshipsResponse{ | ||
| ReadAt: zedtoken.NewFromRevision(*atRevision), |
There was a problem hiding this comment.
build the token outside of the loop?
Signed-off-by: Jake Moshenko <jacob.moshenko@gmail.com>
Signed-off-by: Jake Moshenko <jacob.moshenko@gmail.com>
jzelinskie
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.