Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/datastore: add observable proxy #952

Merged
merged 1 commit into from Oct 27, 2022
Merged

internal/datastore: add observable proxy #952

merged 1 commit into from Oct 27, 2022

Conversation

jzelinskie
Copy link
Member

This pulls out all tracing into one proxy to deduplicate some boilerplate around tracing the datastore.

@jzelinskie jzelinskie requested review from vroldanbet and a team as code owners October 27, 2022 17:43
@github-actions github-actions bot added area/CLI Affects the command line area/datastore Affects the storage system labels Oct 27, 2022
vroldanbet
vroldanbet reviewed Oct 27, 2022
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it deliberate to delete a bunch of event / attributes added in the controller method? Why not just fetching the span from the context and leaving those calls there?

@jzelinskie
Copy link
Member Author

Was it deliberate to delete a bunch of event / attributes added in the controller method? Why not just fetching the span from the context and leaving those calls there?

I wanted to just make everything consistent for now. Is there any specific ones that you think are worth keeping?

@jzelinskie
internal/datastore: add observable proxy
76baafb 
This pulls out all tracing into one proxy to deduplicate some
boilerplate around tracing the datastore.
vroldanbet
vroldanbet approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's start by getting the fundamentals (method level granularity) right, and we can do a later pass adding what we feel is the most useful information in each method

@jzelinskie jzelinskie merged commit d226e2a into authzed:main Oct 27, 2022
@jzelinskie jzelinskie deleted the observable.go branch October 27, 2022 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2022
@ecordell
Copy link
Contributor

Several of the wrappers omit SeparateContextWithTracing - is that intentional?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vroldanbet vroldanbet vroldanbet approved these changes

@jakedt jakedt Awaiting requested review from jakedt

Assignees
No one assigned
Labels
area/CLI Affects the command line area/datastore Affects the storage system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jzelinskie @ecordell @vroldanbet