Add a relationships read command
#50
Conversation
josephschorr
force-pushed
the
read-rel-cmd
branch
from
9e250ea
to
4d4b1f2
Compare
josephschorr
changed the title
read relationships command
| RelationshipFilter: readFilter, | ||
| } | ||
| if zedtoken := cobrautil.MustGetString(cmd, "revision"); zedtoken != "" { | ||
| request.Consistency = &v1.Consistency{ |
There was a problem hiding this comment.
Should it? What is the most likely "expected' behavior?
There was a problem hiding this comment.
I think this is reasonable until we address #37
There was a problem hiding this comment.
I'm honestly not 100% sure which is the preferred solution, but I think its better to just use the at least as for now, since you'll likely want to see the state of the world at which a Check would operate
There was a problem hiding this comment.
read in zanzibar is snapshot... which is consistent with v0
There was a problem hiding this comment.
Right, but that's not the default now in V1 (I believe)
| request := &v1.ReadRelationshipsRequest{ | ||
| RelationshipFilter: readFilter, | ||
| } |
There was a problem hiding this comment.
style nitpick, this could be one line
Signed-off-by: Joseph Schorr <josephschorr@users.noreply.github.com>
josephschorr
force-pushed
the
read-rel-cmd
branch
from
4d4b1f2
to
d49485d
Compare
jzelinskie
added
area/CLI
jzelinskie
changed the title
read relationships commandrelationships read command
jakedt
dismissed
their stale review
We can wait until the follow-up for the requested changes.
No description provided.