Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #512

Merged
merged 1 commit into from
May 22, 2024
Merged

Fix CI #512

merged 1 commit into from
May 22, 2024

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented May 21, 2024

Currently our CI is failing even on main branch.

https://github.com/autifyhq/autify-cli/actions/runs/8731062511

I noticed we use Node v18 even we have a deinition for the version here

autify-cli/package.json

Lines 177 to 179 in 7236d06

"engines": {
"node": ">=20.11.0"
},

We'll need to update Node version eventually, but I'd like to fix our CI first with minimum change.


I confirmed it can pass with v18.20.1 but not with 18.20.2 and .3

With 18.20.3

34fd8b5

https://github.com/autifyhq/autify-cli/actions/runs/9183977901/job/25255635925

image

With 18.20.2

f2fcd91

https://github.com/autifyhq/autify-cli/actions/runs/9184279256/job/25256414727

image

@mtsmfm mtsmfm force-pushed the fix-ci branch 2 times, most recently from f2fcd91 to 5409165 Compare May 22, 2024 02:39
@mtsmfm mtsmfm marked this pull request as ready for review May 22, 2024 04:59
@mtsmfm mtsmfm requested review from a team and Yarimizu14 and removed request for a team May 22, 2024 04:59
Copy link
Contributor

@Yarimizu14 Yarimizu14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

Copy link
Contributor

@4ydx 4ydx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mtsmfm mtsmfm merged commit 543901a into main May 22, 2024
58 checks passed
@mtsmfm mtsmfm deleted the fix-ci branch May 22, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants