refactor(filters): checkMaxDownloads #1285
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor style thing I ran into while researching autobrr/autobrr.com#147 feel free to ignore if you don't like it.
Two related questions:
if len(...) >0
at the end. I thought that was mysterious.now
. I was thinking about adding a comment here https://github.com/autobrr/autobrr/blob/develop/internal/database/filter.go#L1416 about what the SQL queries are doing, sort of analogous to more explanation for "max per" autobrr.com#147. Would be interested in adding the rationale in the comment too.