more explanation for "max per" #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for autobrr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/filters/basics.md
Outdated
|
|
||
| † If "Max downloads" is set, the filter will only match if you have downloaded fewer than "max downloads" items since the beginning of the "max downloads per" period. For instance, if you set "max downlods" to 3 and "max downloads per" to "day" the filter won't match unless you have downloaded fewer than 3 items since the beginning of the current day, in local time. |
There was a problem hiding this comment.
I'd suggest replace that crucifix for the blue info box like we have in many other places. It may look more familiar.
switch to `:::info`
|
How's this? I copied what I saw elsewhere but not sure how to check if it renders properly. |
s0up4200
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is how it works after reading
https://github.com/autobrr/autobrr/blob/develop/internal/database/filter.go#L1424-L1472
I had originally guessed that the count was over a rolling "download period" sized lookback window, thought other people might also have been confused.