Remove extraneous whitespace to make ifelse() work #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've marked the macro obsolete in a66131f. Thank you for the suggestion! |
|
Thanks! |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Dec 4, 2019
Change log: * Noteworthy changes in release 2019.01.06 (2019-01-06) [stable] The Autoconf Archive now has its own organization on Github. Therefore, the mirror has moved to https://github.com/autoconf-archive/autoconf-archive. The old location, https://github.com/peti/autoconf-archive redirects there. The macro AX_CODE_COVERAGE was modified to use AX_ADD_AM_MACRO_STATIC, and thus unfortunately usage was changed. * Noteworthy changes in release 2018.03.13 (2018-03-13) [stable] The macros AX_R_PACKAGE and AX_PROG_DATE have been added. Many other macros have received updates. * Noteworthy changes in release 2017.09.28 (2017-09-28) [stable] The macros AX_PROG_HELP2MAN, AX_RECURSIVE_EVAL, AX_SUBDIRS_CONFIGURE, AX_ELISP, and AX_PROG_EMACS have been added. Various macros have received updates. Please check the ChangeLog file or the history of the git repository for further details. * Noteworthy changes in release 2017.03.21 (2017-03-21) [stable] Obsolete macros AX_CXX_COMPILER_VENDOR, AX_GCC_LIBRARIES_DIR, AX_GCC_VERSION, and AX_HAVE_OPENGL have been removed from the archive. AX_DEFINE_SUB_PATH has been marked obsolete as suggested in autoconf-archive/autoconf-archive#97.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when trying to figure out what this macro is useful for. I have to admit that I still don’t know…? Could you explain what the intended use-case is?
I was hoping it could be used for defining a C preprocessor macro (via
AC_DEFINE) that contained an expanded ${sysconfdir}, but — even with the necessary bugfixes — the description says the macro will merely replace${prefix}with a dotslash.In the end, I resorted to using:
Also, should we consider deleting the macro entirely instead of merging this pull request? As per https://codesearch.debian.net/search?q=AX_DEFINE_SUB_PATH and https://codesearch.debian.net/search?q=AC_DEFINE_SUB_PATH and a quick Google search, there are no users of this macro (not surprising as it’s broken, but nobody cared enough to submit a fix until now).