Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm options for Mac result in very slow build times #1335

Open
kwokcb opened this issue Nov 24, 2021 · 2 comments
Open

Arm options for Mac result in very slow build times #1335

kwokcb opened this issue Nov 24, 2021 · 2 comments
Milestone

Comments

@kwokcb
Copy link
Collaborator

kwokcb commented Nov 24, 2021

This matrix option using CMAKE_OSX_ARCHITECTURES ends up running quite slow in CI.
About 40 min with vs 10 min without.
The adverse affect is that all developers need to wait about triple the time for PRs. (It's not run on regular pushes.)

  • name: MacOS_Xcode_13_Python38
    os: macos-11
    compiler: xcode
    compiler_version: "13.0"
    python: 3.8
    cmake_config: -DCMAKE_OSX_ARCHITECTURES="arm64;x86_64"
@ashwinbhat
Copy link
Collaborator

We can remove the universal binaries setting and switch only to arm64

@kwokcb kwokcb added this to the 1.38.4 milestone Jan 18, 2022
@kwokcb
Copy link
Collaborator Author

kwokcb commented Jan 18, 2022

Queuing for 1.38.4 as the wait time is a nuisance as it's done on each push / PR.

ashwinbhat pushed a commit that referenced this issue Apr 25, 2023
For the swizzling logic on inputs in the base shader generator, the returned type of the Value after swizzling can be incorrect as it looks up the type based on the Value's Type as mapped to a TypeDesc -- as opposed just the Type. The TypeDesc type can end up not being a valid Type which results in a default string Value being returned.

This occurs for the "channels" conversion for instance for "color3" for MSL and GLSL as the TypeDesc type is "vec3" instead of the correct type which is "color3".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants