Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legacy graphs Normals Fixes #1402

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Conversation

zicher3d
Copy link
Collaborator

Adding defaultgeomprop attributes
Unifying default values for vector3 inputs
Fixing wrong normal conversion in Glass graph
Fixing wrong default normal constant in Generic graph

Adding defaultgeomprop attributes
Unifying default values for vector3 inputs
Fixing wrong normal conversion in Glass graph
Fixing wrong default normal constant in Generic graph
@zicher3d zicher3d requested a review from ashwinbhat June 26, 2024 22:56
@zicher3d zicher3d self-assigned this Jun 26, 2024
Copy link
Collaborator

@ashwinbhat ashwinbhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zicher3d zicher3d merged commit e9c7668 into adsk_contrib/dev Jun 27, 2024
30 of 32 checks passed
@zicher3d zicher3d deleted the zicher/normals_fixes branch June 27, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants