Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[multimodal] fix missing detection configs during package installation #3155

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

FANGAreNotGnu
Copy link
Contributor

Fix for #3152 and #3082

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@FANGAreNotGnu FANGAreNotGnu changed the title fix that detection configs are missing in pip install [multimodal] fix missing detection configs in pypi Apr 17, 2023
@FANGAreNotGnu FANGAreNotGnu changed the title [multimodal] fix missing detection configs in pypi [multimodal] fix missing detection configs during package installation Apr 17, 2023
Copy link
Contributor

@zhiqiangdon zhiqiangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why our CI didn't encounter the errors in the issues.

@FANGAreNotGnu
Copy link
Contributor Author

Wondering why our CI didn't encounter the errors in the issues.

I think it's because CI somehow copied all the source files. @gradientsky @yinweisu Could you check if these fixes would work (or at least not breaking anything)? I'll have to merge and wait for the nightly build to test.

@github-actions
Copy link

Job PR-3155-00d68e2 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-3155/00d68e2/index.html

Copy link
Contributor

@zhiqiangdon zhiqiangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's check the nightly build later.

@zhiqiangdon zhiqiangdon merged commit ab6fc9a into autogluon:master Apr 18, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants