[multimodal] fix python packages missing __init__.py
#3158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gradientsky
changed the title
__init__.py
|
Cli and configs are not directly imported in other files. I'm not sure if we shall treat them as packages. |
|
Job PR-3158-33db9b7 is done. |
yinweisu
approved these changes
Apr 19, 2023
zhiqiangdon
reviewed
Apr 19, 2023
| @@ -83,11 +83,6 @@ | |||
| "configs/environment/*.yaml", | |||
| "configs/distiller/*.yaml", | |||
| "configs/matcher/*.yaml", | |||
There was a problem hiding this comment.
If we put __init__.py in configs, can we remove the yaml files here?
This was referenced Apr 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3155
Description of changes:
__init__.pyto python packages.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.