-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[timeseries] fix random seed, reset seed for every model #3934
Merged
canerturkmen
merged 6 commits into
autogluon:master
from
canerturkmen:ts-fix-model-seeding
Feb 20, 2024
Merged
[timeseries] fix random seed, reset seed for every model #3934
canerturkmen
merged 6 commits into
autogluon:master
from
canerturkmen:ts-fix-model-seeding
Feb 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canerturkmen
added
bug
Something isn't working
module: timeseries
related to the timeseries module
labels
Feb 19, 2024
shchur
reviewed
Feb 20, 2024
shchur
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Feel free to merge once the tests pass.
canerturkmen
added a commit
that referenced
this pull request
Apr 14, 2024
This reverts commit ab73555.
LennartPurucker
pushed a commit
to LennartPurucker/autogluon
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3896
#3923
Description of changes:
Previously,
seed_everything
was called once at the beginning ofTimeSeriesPredictor
fit
andpredict
methods which led to two undesirable side effects:random_seed
provided by the user. This was done, e.g., inRecursiveTabular
'sNN_TORCH
affectinghigh_quality
presets.With this change, we propagate the random seed to the learner and trainer both at training and prediction time. We set the seed again, per model, when fitting single models or predicting with single models.
Also fixes a minor issue in predictor unit tests.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.