Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[timeseries] Fix windows platform tests logfile permission error #4041

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

AnirudhDagar
Copy link
Contributor

Issue #, if available:
Windows platform tests for timeseries are failing due to a permission error on removing a logfile that is being used by another process.

Description of changes:
This was introduced due to changes made in #3934 specifically these two lines were added to clean up the test directory (see comment: https://github.com/autogluon/autogluon/pull/3934/files#r1495459186). So this is a test specific fix for windows, and we skip removing the custom_log file in windows tests.:

finally:
log_path.unlink(missing_ok=True)

Thanks @shchur for helping setup the machine and sharing some context on the issue.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AnirudhDagar
Copy link
Contributor Author

AnirudhDagar commented Apr 5, 2024

/platform_tests ref=ts_platform_test_fix
Platform Tests Output

@yinweisu
Copy link
Collaborator

yinweisu commented Apr 5, 2024

Previous CI Run Current CI Run

Copy link
Contributor

@canerturkmen canerturkmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Thanks @AnirudhDagar !!

@AnirudhDagar
Copy link
Contributor Author

AnirudhDagar commented Apr 5, 2024

Remaining errors in timeseries windows platform tests are coming from test_chronos.py, due to the path generated incorrectly. I'm taking a look at that now, will send a separate fix for that.

@AnirudhDagar AnirudhDagar merged commit 4e429a0 into autogluon:master Apr 5, 2024
27 checks passed
Copy link

github-actions bot commented Apr 5, 2024

Job PR-4041-6751935 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-4041/6751935/index.html

LennartPurucker pushed a commit to LennartPurucker/autogluon that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants