Develop slowtypemethod #596

sebastiansam55 · 2021-08-24T11:32:46Z

Adds the option to have a delay between sending keystrokes, as has been suggested as a solution to issues with trigger phrases not being completely removed. If we could get someone who has this problem to confirm that this would be a fix I'll work on adding the option to the Gtk UI.

Right now I have it set up to use the same delay for both the backspaces to remove a trigger word and the phrase itself.

If you want to test this you need to clone this branch git clone https://github.com/sebastiansam55/autokey --branch develop-slowtypemethod, go to the lib directory in the terminal and launch via python3 -m autokey.gtkui -lc (Qt should reflect these changes as well). Then open the json file of the phrase that you want to type with a delay and add "type_delay": 0.1 to the end, making sure that the json is properly formatted.

My config file is pictured below

The change uses python's time.sleep() method and is only activated when type_delay is greater than or equal to 0.

If someone can confirm this fix I can;

add this to the UI
add it for abbreviation triggers for scripts
Add a keyboard module method

josephj11 · 2021-08-24T21:17:28Z

Nice. Looking forward to seeing if this addresses some of the other issues we are seeing.

BlueDrink9 · 2021-08-25T20:45:10Z

Very good. ~~Do you think it would be too difficult to make this a per-phrase option rather than global?~~ EDIT: Nvm, my apologies it is per-phrase.

sebastiansam55 · 2021-08-25T20:51:53Z

Well it is per phrase, it pulls the type delay from the json file for each phrase, and phrase.py sets the default value to 0, so if one is not present it's 0. And in the set_string arguments it defaults to 0 in the arguments for the function so when something calls it that doesn't include the variable it skips the time.sleep.

BlueDrink9

The backend stuff looks great, considering the mess we are working with. I can't think of any better way to implement this

BlueDrink9 · 2021-08-25T20:58:25Z

lib/autokey/interface.py

@@ -787,6 +787,10 @@ def __sendString(self, string):
                        self.__releaseKey(Key.SHIFT)
                else:
                    logger.warning("Unable to send character %r", char)
+                logger.info("Type delay of "+str(type_delay))
+                if type_delay >= 0:
+                    self.localDisplay.flush()


I don't like that this is duplicated at iomediator.py:247.

I think it would be better to remove any mention of type_delay from interface.py, put this 3/4 lines in a function in iomediator.py, and replace your calls to send_key with that new function (if that makes sense)

Oh actually I forgot how bloated sendString is on this fork; my refactor branch tidied it up a huge amount. Leave this as-is for now, I think.

BlueDrink9 · 2021-08-25T20:58:31Z

lib/autokey/iomediator/iomediator.py

        """
        Sends the given number of backspace key presses.
        """
        for i in range(count):
            self.interface.send_key(Key.BACKSPACE)
+            if type_delay >= 0:
+                time.sleep(type_delay)


See previous note about duplicating these 3 lines

BlueDrink9 · 2021-08-25T21:02:05Z

lib/autokey/model/phrase.py

@@ -84,7 +85,8 @@ def get_serializable(self):
            "abbreviation": AbstractAbbreviation.get_serializable(self),
            "hotkey": AbstractHotkey.get_serializable(self),
            "filter": AbstractWindowFilter.get_serializable(self),
-            "sendMode": self.sendMode.value
+            "sendMode": self.sendMode.value,
+            "type_delay": self.type_delay


If syntax permits, may as well add a comma at the end of the line to make tidier diffs for next time. (See Black for reasoning)

BlueDrink9 · 2021-08-25T21:06:33Z

As a side note, if you rebase on develop and push again the tests should be fixed.

josephj11 · 2021-08-26T21:35:15Z

This looks like a step in the right direction. The function that @bjohas enhanced in #566 has three separate optional delay parameters, so I'm not sure if reducing it to just one will cover all cases.

BlueDrink9 · 2021-08-29T00:09:59Z

Also, if you add this to a gui don't forget to also add it to engine.create_phrase in the scripting api if appropriate.

(Also update changelog)

bjohas · 2021-08-30T19:06:15Z

This looks like a step in the right direction. The function that @bjohas enhanced in #566 has three separate optional delay parameters, so I'm not sure if reducing it to just one will cover all cases.

I haven't experimented extensively with it, but it seems to me that the typing/deleting speed is one thing but that introducing a delay when switching from deleting to typing seems to be important. So you could be losing a lot of time introducing delays between letters, when really what you want is a delay when switching from deleting to typing.

Of course - once all the delays are large enough, it doesn't matter, but I had to introduce quite significant delays between letters. Introducing a delay when switching from deleting to typing meant faster execution overall.

The model I ended up with is in #566, where I actually didn't have a delay between letters at all, but just a delay when switching over. I don't know why that is, but somehow deleting and typing seem to be handled differently. Hope that helps.

… a prexisting method

BlueDrink9 · 2021-09-03T21:28:00Z

lib/autokey/scripting/keyboard.py

@@ -45,7 +60,7 @@ def send_keys(self, key_string, send_mode: typing.Union[

        Usage: C{keyboard.send_keys(keyString)}

-        @param key_string: string of keys to send. Special keys are only possible in keyboard mode.
+        @param key_string: 


What reasoning for removing this docstring?

BlueDrink9 · 2021-09-08T04:05:11Z

I have just rebased this against the newly-refactored develop. I suggest you reset --hard to https://github.com/BlueDrink9/autokey/tree/sebastiansam55-develop-slowtypemethod

allanlaal · 2021-12-26T13:32:38Z

@sebastiansam55 just tried branch develop-slowtypemethod tip. seems to work ok with medium load and loooong urls :)

altough Quit will remove "type_delay from autokey.json

allanlaal · 2021-12-26T14:34:09Z

I set "type_delay": 0.001

I can't remember if this has already been discovered, but it seems with superfast keyboard emulation typing there is not enough time for entering keycombo characters like : / ? = & (shift + numrow keys on my estonian layout):
httpsxgis.maaamet.eemapsisappid82useridat11620958zlevel10,549052.10876467,6546996.6812135setlegend1821

Expected:
https://xgis.maaamet.ee/maps/XGis?app_id=UU82A&user_id=at&LANG=1&WIDTH=1620&HEIGHT=958&zlevel=10,549052.10876467,6546996.6812135&setlegend=UUKAT1_82=1

the tool I use to diff the results: https://www.convertonline.io/url/diff

"type_delay": 0.3 is the quickest that works for me (2.50GHz × 8 i7 at 80..150% (load: 7..14) + 32GB RAM, SSD)
this workaround is by definition so slow that with longer autocompletes I might aswell go make coffee while I wait, which kinda negates the point of using text files to copypaste stuff from vs Autokey. has there been any other alternatives to slow typing? I tend to use my computer at its limit and other apps need 10x more load to start acting weird :|

sebastiansam55 added 2 commits August 24, 2021 07:18

Adds phrase delay option to json file for phrases.

0ed998f

Add backspace delay using the same variable.

ca3f5d6

This was referenced Aug 24, 2021

Add new Paste using option for slow applications #566

Open

Insert phrase using abbreviation and tab not working as expected #584

Open

josephj11 mentioned this pull request Aug 24, 2021

Trigger word is not removed in Thunderbird #529

Open

BlueDrink9 reviewed Aug 25, 2021

View reviewed changes

sebastiansam55 added 2 commits August 26, 2021 08:04

Add keyboard slow_type method

68001fa

Add comma

1783e5b

Add type delay to engine.create_phrase and update interface.py to use…

9d44df5

… a prexisting method

BlueDrink9 reviewed Sep 3, 2021

View reviewed changes

josephj11 mentioned this pull request Nov 11, 2021

Substitution erases characters before it #624

Open

allanlaal mentioned this pull request Dec 26, 2021

FIX slowtypemethod: algorithm still inputs with losses BlueDrink9/autokey#6

Closed

allanlaal mentioned this pull request Dec 26, 2021

Phrases are sometimes incorrectly expanded, missing character(s) #151

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Develop slowtypemethod #596

Develop slowtypemethod #596

sebastiansam55 commented Aug 24, 2021

josephj11 commented Aug 24, 2021

BlueDrink9 commented Aug 25, 2021 •

edited

sebastiansam55 commented Aug 25, 2021

BlueDrink9 left a comment

BlueDrink9 Aug 25, 2021

BlueDrink9 Aug 25, 2021

BlueDrink9 Aug 25, 2021

BlueDrink9 Aug 25, 2021

BlueDrink9 commented Aug 25, 2021

josephj11 commented Aug 26, 2021

BlueDrink9 commented Aug 29, 2021

bjohas commented Aug 30, 2021 •

edited

BlueDrink9 Sep 3, 2021

BlueDrink9 commented Sep 8, 2021

allanlaal commented Dec 26, 2021 •

edited

allanlaal commented Dec 26, 2021 •

edited

Develop slowtypemethod #596

Are you sure you want to change the base?

Develop slowtypemethod #596

Conversation

sebastiansam55 commented Aug 24, 2021

josephj11 commented Aug 24, 2021

BlueDrink9 commented Aug 25, 2021 • edited

sebastiansam55 commented Aug 25, 2021

BlueDrink9 left a comment

Choose a reason for hiding this comment

BlueDrink9 Aug 25, 2021

Choose a reason for hiding this comment

BlueDrink9 Aug 25, 2021

Choose a reason for hiding this comment

BlueDrink9 Aug 25, 2021

Choose a reason for hiding this comment

BlueDrink9 Aug 25, 2021

Choose a reason for hiding this comment

BlueDrink9 commented Aug 25, 2021

josephj11 commented Aug 26, 2021

BlueDrink9 commented Aug 29, 2021

bjohas commented Aug 30, 2021 • edited

BlueDrink9 Sep 3, 2021

Choose a reason for hiding this comment

BlueDrink9 commented Sep 8, 2021

allanlaal commented Dec 26, 2021 • edited

allanlaal commented Dec 26, 2021 • edited

BlueDrink9 commented Aug 25, 2021 •

edited

bjohas commented Aug 30, 2021 •

edited

allanlaal commented Dec 26, 2021 •

edited

allanlaal commented Dec 26, 2021 •

edited