Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document life of a connection and event flow #233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

itayd
Copy link
Contributor

@itayd itayd commented May 1, 2024

No description provided.

@itayd itayd requested review from tebeka, efiShtain, daabr and ig-ra May 1, 2024 08:31
Copy link
Contributor

@daabr daabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with nits. Thanks for the info.

@@ -0,0 +1,19 @@
# Life of a Connection
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments:

  1. I think this belongs in https://docs.autokitteh.com/concepts/connection
  2. "Life of a" titles carry some credibility with Googlers and Xooglers, but other than that... Meh...
  3. A few English nits, not important right now

- **Name**, this is used to reference the connection in code and configuration
- **Integration** that this connection is representing
- **Project** that this connection serves
2. Most connections need to be configured. The configuration is persisted as **Connection Variables**. These are very much like environment variables, but resided in a scope of a specific connection. This is done using the _Vars_ service. The variables can be set either automatically by the integration, using the UI or manually by the user via APIs. One example of such configuration is OAuth flow, described below.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done using the Vars service.

"Service"? Maybe "section"?


## OAuth

Some connections require OAuth authentication in order to function. Autokitteh provides an _OAuth_ service that knows the steps of the OAuth dance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This is not the docs repo, but still... IIRC, we agreed to use "AutoKitteh" in docs?
  2. This is a problematic section, it's useful for me but I think it's more confusing than explanatory for the average reader, but we can fix this later when we transition this to the docs repo.

@@ -0,0 +1,9 @@
# Life of an Event

1. For example, an external provider sends some data to an integration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. For example, an external provider sends some data to an integration.
1. An external provider sends data to an integration asynchronously.

@@ -0,0 +1,9 @@
# Life of an Event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page would benefit a lot from a flow diagram below the steps. You can create one with markdown - both in GH and Docusaurus I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants