Use omniauthv2-shibboleth for omniauth v2 compat #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compatibility with omniauth v2, use a forked version of the otherwise unmaintained omniauth-shibboleth gem
|
This is actually ready for review now. The first version used the "wrong" forked gem. Apparently gilab is using https://github.com/omniauth/omniauth-shibboleth-redux |
|
Read changelogs of psych and stringio, does not seem to affect autolab. LGTM |
KesterTan
approved these changes
Jul 11, 2023
NicholasMy
pushed a commit
to UB-CSE-IT/Autolab
that referenced
this pull request
Jan 4, 2024
Use omniauth-shibboleth-redux For compatibility with omniauth v2, use a forked version of the otherwise unmaintained omniauth-shibboleth gem (cherry picked from commit de56f91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summary generated by Reviewpad on 29 Jun 23 14:07 UTC
This pull request updates the usage of the
omniauth-shibbolethgem to version1.3.2in the Gemfile, replacing the previous version1.1.2. This change allows for compatibility withomniauthversion 2.0.0 or higher. The Gemfile.lock has been updated accordingly.Description
Swap out the omniauth-shibboleth gem for omniauthv2-shibboleth (from https://github.com/lukaskoenen/omniauth-shibboleth)
Motivation and Context
The original omniauth-shibboleth gem has been unmaintained since 2018, and is not compatible with omniauth 2.x and ruby 3.x. A possibly unintended consequence of #1380 was that omniauth 2.0 was introduced.
The omniauth-shibboleth gem was forked and updated so that gitlab could use shibboleth with omniauth 2.0 (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/121235). Autolab can also make use of it!
This change does NOT obsolete #1593. There are use cases for both generic SAML authentication and shibboleth
How Has This Been Tested?
Types of changes
Checklist:
overcommit --install && overcommit --signto use pre-commit hook for lintingOther issues / help required
I will run tests shortly and update here.