Fix student search bar #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
nayak16
pushed a commit
that referenced
this pull request
May 2, 2017
* Fixed Date time picker always displaying 12AM * move get child status to after moss command (#817) * Update .gitignore to ignore .vscode configs Namely address launch.json but also removes any additional vscode IDE-specific configurations * Hotfix tabs redirect (#824) * fixed problems page redirect * set up tab redirects by including a tag with each submit button * Fixed basic bug and commented code * removed vscode * Removed production devise config from .travis.yml (#834) * set z-index for annotation forms (#813) * Fix submit buttons on penalties and handin page. (#829) * update gradesheet sorting function to better handle NaN (#833) * disable browser autocomplete for username in extensions (#832) * change how datepickers get default date (#846) * Remove 'waves' effect from buttons. (#837) * Add overflow to large title assignments so the badge within the link functions properly. (#848) * Fix student search bar (#853) * Added search table * Fixed student search bar * Update PDF annotation button style (#849) * Update PDF annotation buttons so that the text is visible as well as the icon. Fixes #814. * Remove unnecessary comment. * Fix issue #844 by stopping propogation of click events in the buttons (#845) * Remove max score check from gradesheet (#841) * Set default date if val is blank (#855) * Leave admin options open on page render (#854) * Assessment Forms UX improvements (#847) * Add script to change times on input on edit handin (#840) * regradeAll: refer to correct submissions variable Fix misuse of @submission in regradeAll and regradeBatch * Freeze flatpickr version (#867) * Various form fixes for readability and clarity (#866) * fix the variable name bug in date picker (#869) * Move the nav drawer to the right side popout. (#857)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per issue #821, the student search bar on the "Create Submission" page searches by first name, but sorts the list by andrewid. This fix replaces that choosing method with a search bar that searches students by either andrewid or first name.