Form fixes jacob #937
Merged
Form fixes jacob #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and have expected behaviors across all forms.
zyx-billy
requested changes
Dec 3, 2017
There was a problem hiding this comment.
Overall looks good to me! I like the new file_field_nowrap. One small concern: there's no indication that a file has been selected. Perhaps it'd be helpful to show the selected filename somewhere?
Also, I'm not sure if this is just showing up for me, but the autocomplete popup on the extensions page seems a bit high, extending into the text field. Mostly caused by the -15px top margin of .autocomplete-content. Perhaps we can find a way to fix this?
|
I have fixed the issues with the embedded quiz form, as well as removed the -15 margin that is seen on autocomplete forms. |
zyx-billy
approved these changes
Dec 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #880. This is mostly stylistic changes to form fields to make them look nicer & be well aligned on pages.