Improve cover art retrieval / prevent errors

[chronicrebellion]

Description

I noticed that when ripping certain CDs, the ARM UI will show unknown for State and ETA along with no cover art.

The log files showed this:
ERROR ARM: music_brainz.music_brainz Try 2 - ERROR: 'NoneType' object has no attribute 'group'
ARM attempts to use robobrowser to find the cover art but there is no cover art image on the page.

We end up trying to extract the image url from None - which is not a WebServiceError and get caught in the Try 2 exception.
The error prevents updating the job with the current number of tracks.

Current Logic
The code chooses the first release to find the cover art.

if there is no cover art present, it uses the release id (same as job.crc_id) to find the cover art image from musicbrainz release page.

The issue here is that if there is no cover art from the info json - there will not be an image on musicbrainz either.

This is the info for Mest - Destination Unknown CD: https://musicbrainz.org/ws/2/discid/5FRS8CUPDRvXXBnoE0Jpzw8SlXU-?inc=artist-credits+recordings

The first release does not have cover art but the second one does.

Proposed Change
I have changed the logic to loop through all the releases to find a release with cover art.
This also means we do not need to use RoboBrowser at all.

If an image exists, it will be shown and the tracks and ETA will be populated in the ARM UI

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

• Docker
• Other (Please state here)

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have tested that my fix is effective or that my feature works

Changelog:

Include the details of changes made here

• Find cover art by looping through releases
• Remove white space from PROCESS_COMPLETE constant
• Update code that uses PROCESS_COMPLETE
• Added a . after Ripping all tracks

Logs

Attach logs from successful test runs here

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[chronicrebellion]

@microtechno9000 could i get a review when you have some free time?

[shitwolfymakes]

Great work!