-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images Fix for Reverse Proxy #997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kudos, SonarCloud Quality Gate passed! |
Can you confirm the change works when not behind a reverse proxy. I presume that this now works behind the reverse proxy. |
Yes, direct access works as well.
…On Mon, Dec 4, 2023 at 2:51 PM Mtech ***@***.***> wrote:
Can you confirm the change works when not behind a reverse proxy. I
presume that this now works behind the reverse proxy.
—
Reply to this email directly, view it on GitHub
<#997 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACKIKRCG3Q4RJAXEPQELZ2LYHYSUFAVCNFSM6AAAAABAGLF7HSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGM3TAMBTG4>
.
You are receiving this because you authored the thread.Message ID:
<automatic-ripping-machine/automatic-ripping-machine/pull/997/c1839370037@
github.com>
|
microtechno9000
approved these changes
Dec 5, 2023
microtechno9000
merged commit Dec 5, 2023
3507800
into
automatic-ripping-machine:main
10 of 11 checks passed
truecharts-admin
added a commit
to truecharts/charts
that referenced
this pull request
Jan 21, 2024
…-ripping-machine to v2.6.69@c364433 by renovate (#17405) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine) | patch | `2.6.67` -> `2.6.69` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>automatic-ripping-machine/automatic-ripping-machine (automaticrippingmachine/automatic-ripping-machine)</summary> ### [`v2.6.69`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.69) [Compare Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.67...2.6.69) #### What's Changed - Add configurable URL for notifications by [@​anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#972 - Bugfix for Music Rips Title issue on initial Job start Issue [#​866](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/866) by [@​microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#980 - Update README-OMDBAPI.md by [@​MNTech68](https://togithub.com/MNTech68) in [automatic-ripping-machine/automatic-ripping-machine#981 - Make the installation/how-to/contributing links longer and easier to click by [@​charmarkk](https://togithub.com/charmarkk) in [automatic-ripping-machine/automatic-ripping-machine#994 - Allow disabling auto-ejects by [@​marcusds](https://togithub.com/marcusds) in [automatic-ripping-machine/automatic-ripping-machine#991 - Fix bad use of "ln -sf" by [@​fizbin](https://togithub.com/fizbin) in [automatic-ripping-machine/automatic-ripping-machine#986 - Images Fix for Reverse Proxy by [@​Jarlotee](https://togithub.com/Jarlotee) in [automatic-ripping-machine/automatic-ripping-machine#997 - Bump tj-actions/branch-names from 7 to 8 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1005 - Bump actions/stale from 8 to 9 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1004 - Bump actions/setup-python from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1002 - Bump docker/metadata-action from 5.0.0 to 5.3.0 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#998 - Bump github/codeql-action from 2 to 3 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1011 - Fixes for when musicbrainz returns a cdstub by [@​fizbin](https://togithub.com/fizbin) in [automatic-ripping-machine/automatic-ripping-machine#990 - bugfix for issue [#​1026](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/1026) - typo in docker-setup.sh by [@​microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#1027 - Bump docker/metadata-action from 5.3.0 to 5.4.0 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1016 - Update greetings.yml by [@​microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#999 - fix: use job.title to show meaningful music notifications by [@​chronicrebellion](https://togithub.com/chronicrebellion) in [automatic-ripping-machine/automatic-ripping-machine#1033 - Improve cover art retrieval / prevent errors by [@​chronicrebellion](https://togithub.com/chronicrebellion) in [automatic-ripping-machine/automatic-ripping-machine#1035 - Bump docker/metadata-action from 5.4.0 to 5.5.0 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1032 - 933 dvd might have a label containing a / by [@​1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#1041 #### New Contributors - [@​MNTech68](https://togithub.com/MNTech68) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#981 - [@​charmarkk](https://togithub.com/charmarkk) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#994 - [@​marcusds](https://togithub.com/marcusds) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#991 - [@​fizbin](https://togithub.com/fizbin) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#986 - [@​Jarlotee](https://togithub.com/Jarlotee) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#997 - [@​chronicrebellion](https://togithub.com/chronicrebellion) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#1033 **Full Changelog**: automatic-ripping-machine/automatic-ripping-machine@2.6.67...2.6.69 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
discretizer
pushed a commit
to discretizer/charts
that referenced
this pull request
Jan 29, 2024
…-ripping-machine to v2.6.69@c364433 by renovate (truecharts#17405) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine) | patch | `2.6.67` -> `2.6.69` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>automatic-ripping-machine/automatic-ripping-machine (automaticrippingmachine/automatic-ripping-machine)</summary> ### [`v2.6.69`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.69) [Compare Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.67...2.6.69) #### What's Changed - Add configurable URL for notifications by [@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#972 - Bugfix for Music Rips Title issue on initial Job start Issue [#&truecharts#8203;866](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/866) by [@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#980 - Update README-OMDBAPI.md by [@&truecharts#8203;MNTech68](https://togithub.com/MNTech68) in [automatic-ripping-machine/automatic-ripping-machine#981 - Make the installation/how-to/contributing links longer and easier to click by [@&truecharts#8203;charmarkk](https://togithub.com/charmarkk) in [automatic-ripping-machine/automatic-ripping-machine#994 - Allow disabling auto-ejects by [@&truecharts#8203;marcusds](https://togithub.com/marcusds) in [automatic-ripping-machine/automatic-ripping-machine#991 - Fix bad use of "ln -sf" by [@&truecharts#8203;fizbin](https://togithub.com/fizbin) in [automatic-ripping-machine/automatic-ripping-machine#986 - Images Fix for Reverse Proxy by [@&truecharts#8203;Jarlotee](https://togithub.com/Jarlotee) in [automatic-ripping-machine/automatic-ripping-machine#997 - Bump tj-actions/branch-names from 7 to 8 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1005 - Bump actions/stale from 8 to 9 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1004 - Bump actions/setup-python from 4 to 5 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1002 - Bump docker/metadata-action from 5.0.0 to 5.3.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#998 - Bump github/codeql-action from 2 to 3 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1011 - Fixes for when musicbrainz returns a cdstub by [@&truecharts#8203;fizbin](https://togithub.com/fizbin) in [automatic-ripping-machine/automatic-ripping-machine#990 - bugfix for issue [#&truecharts#8203;1026](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/1026) - typo in docker-setup.sh by [@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#1027 - Bump docker/metadata-action from 5.3.0 to 5.4.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1016 - Update greetings.yml by [@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#999 - fix: use job.title to show meaningful music notifications by [@&truecharts#8203;chronicrebellion](https://togithub.com/chronicrebellion) in [automatic-ripping-machine/automatic-ripping-machine#1033 - Improve cover art retrieval / prevent errors by [@&truecharts#8203;chronicrebellion](https://togithub.com/chronicrebellion) in [automatic-ripping-machine/automatic-ripping-machine#1035 - Bump docker/metadata-action from 5.4.0 to 5.5.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1032 - 933 dvd might have a label containing a / by [@&truecharts#8203;1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#1041 #### New Contributors - [@&truecharts#8203;MNTech68](https://togithub.com/MNTech68) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#981 - [@&truecharts#8203;charmarkk](https://togithub.com/charmarkk) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#994 - [@&truecharts#8203;marcusds](https://togithub.com/marcusds) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#991 - [@&truecharts#8203;fizbin](https://togithub.com/fizbin) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#986 - [@&truecharts#8203;Jarlotee](https://togithub.com/Jarlotee) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#997 - [@&truecharts#8203;chronicrebellion](https://togithub.com/chronicrebellion) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#1033 **Full Changelog**: automatic-ripping-machine/automatic-ripping-machine@2.6.67...2.6.69 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
GabrielBarzen
pushed a commit
to GabrielBarzen/charts
that referenced
this pull request
Feb 2, 2024
…-ripping-machine to v2.6.69@c364433 by renovate (truecharts#17405) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine) | patch | `2.6.67` -> `2.6.69` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>automatic-ripping-machine/automatic-ripping-machine (automaticrippingmachine/automatic-ripping-machine)</summary> ### [`v2.6.69`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.69) [Compare Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.67...2.6.69) #### What's Changed - Add configurable URL for notifications by [@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#972 - Bugfix for Music Rips Title issue on initial Job start Issue [#&truecharts#8203;866](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/866) by [@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#980 - Update README-OMDBAPI.md by [@&truecharts#8203;MNTech68](https://togithub.com/MNTech68) in [automatic-ripping-machine/automatic-ripping-machine#981 - Make the installation/how-to/contributing links longer and easier to click by [@&truecharts#8203;charmarkk](https://togithub.com/charmarkk) in [automatic-ripping-machine/automatic-ripping-machine#994 - Allow disabling auto-ejects by [@&truecharts#8203;marcusds](https://togithub.com/marcusds) in [automatic-ripping-machine/automatic-ripping-machine#991 - Fix bad use of "ln -sf" by [@&truecharts#8203;fizbin](https://togithub.com/fizbin) in [automatic-ripping-machine/automatic-ripping-machine#986 - Images Fix for Reverse Proxy by [@&truecharts#8203;Jarlotee](https://togithub.com/Jarlotee) in [automatic-ripping-machine/automatic-ripping-machine#997 - Bump tj-actions/branch-names from 7 to 8 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1005 - Bump actions/stale from 8 to 9 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1004 - Bump actions/setup-python from 4 to 5 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1002 - Bump docker/metadata-action from 5.0.0 to 5.3.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#998 - Bump github/codeql-action from 2 to 3 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1011 - Fixes for when musicbrainz returns a cdstub by [@&truecharts#8203;fizbin](https://togithub.com/fizbin) in [automatic-ripping-machine/automatic-ripping-machine#990 - bugfix for issue [#&truecharts#8203;1026](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/1026) - typo in docker-setup.sh by [@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#1027 - Bump docker/metadata-action from 5.3.0 to 5.4.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1016 - Update greetings.yml by [@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#999 - fix: use job.title to show meaningful music notifications by [@&truecharts#8203;chronicrebellion](https://togithub.com/chronicrebellion) in [automatic-ripping-machine/automatic-ripping-machine#1033 - Improve cover art retrieval / prevent errors by [@&truecharts#8203;chronicrebellion](https://togithub.com/chronicrebellion) in [automatic-ripping-machine/automatic-ripping-machine#1035 - Bump docker/metadata-action from 5.4.0 to 5.5.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#1032 - 933 dvd might have a label containing a / by [@&truecharts#8203;1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#1041 #### New Contributors - [@&truecharts#8203;MNTech68](https://togithub.com/MNTech68) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#981 - [@&truecharts#8203;charmarkk](https://togithub.com/charmarkk) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#994 - [@&truecharts#8203;marcusds](https://togithub.com/marcusds) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#991 - [@&truecharts#8203;fizbin](https://togithub.com/fizbin) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#986 - [@&truecharts#8203;Jarlotee](https://togithub.com/Jarlotee) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#997 - [@&truecharts#8203;chronicrebellion](https://togithub.com/chronicrebellion) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#1033 **Full Changelog**: automatic-ripping-machine/automatic-ripping-machine@2.6.67...2.6.69 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xNDAuMTYiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running Arm behind a reverse proxy (like nginx) works well with the exception of these image paths which accidently have a double // in the resulting html.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Build the docker image, confirm that images are still displaying correctly
Checklist:
Changelog:
Include the details of changes made here