Add option to disable ejection on an unidentified disc (#779) #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martini1992
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
shitwolfymakes
approved these changes
Sep 24, 2023
shitwolfymakes
merged commit 9064600
into
automatic-ripping-machine:main
10 checks passed
truecharts-admin
added a commit
to truecharts/charts
that referenced
this pull request
Jan 3, 2024
…-ripping-machine to v2.6.67@8310b23 by renovate (#16800) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine) | patch | `2.6.60` -> `2.6.67` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>automatic-ripping-machine/automatic-ripping-machine (automaticrippingmachine/automatic-ripping-machine)</summary> ### [`v2.6.67`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.67) [Compare Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.60...2.6.67) #### What's Changed - Fix for 914 - automatic build/release creating new release everytime by [@​1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#917 - Bump docker/setup-buildx-action from 2.9.1 to 2.10.0 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#920 - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#932 - Ntfy and Bash for notifications by [@​newhinton](https://togithub.com/newhinton) in [automatic-ripping-machine/automatic-ripping-machine#930 - Fix handling of the abcde.conf file for docker by [@​martini1992](https://togithub.com/martini1992) in [automatic-ripping-machine/automatic-ripping-machine#938 - Add option to disable ejection on an unidentified disc ([#​779](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/779)) by [@​martini1992](https://togithub.com/martini1992) in [automatic-ripping-machine/automatic-ripping-machine#937 - Bump docker/build-push-action from 4 to 5 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#940 - Bump docker/metadata-action from 4.6.0 to 5.0.0 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#943 - Bump docker/setup-buildx-action from 2.10.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#941 - Bump docker/login-action from 2.2.0 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#942 - Add k10temp support for more AMD platforms by [@​anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#958 - Fix transcode free space by [@​rgooler](https://togithub.com/rgooler) in [automatic-ripping-machine/automatic-ripping-machine#954 - Add Apprise test button by [@​anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#963 - Resolved issue with dev tools by [@​microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#966 - Use Waitress as WSGI Server by [@​anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#964 - Bump arm-dependencies from `0d608cb` to `c3b0745` by [@​dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#970 - Parse bluray label for OMDB search by [@​anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#962 - Models Refactor by [@​shitwolfymakes](https://togithub.com/shitwolfymakes) in [automatic-ripping-machine/automatic-ripping-machine#977 #### New Contributors - [@​martini1992](https://togithub.com/martini1992) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#938 - [@​anthonylavado](https://togithub.com/anthonylavado) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#958 - [@​rgooler](https://togithub.com/rgooler) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#954 **Full Changelog**: automatic-ripping-machine/automatic-ripping-machine@2.6.60...2.6.67 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
GabrielBarzen
pushed a commit
to GabrielBarzen/charts
that referenced
this pull request
Feb 2, 2024
…-ripping-machine to v2.6.67@8310b23 by renovate (truecharts#16800) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine) | patch | `2.6.60` -> `2.6.67` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>automatic-ripping-machine/automatic-ripping-machine (automaticrippingmachine/automatic-ripping-machine)</summary> ### [`v2.6.67`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.67) [Compare Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.60...2.6.67) #### What's Changed - Fix for 914 - automatic build/release creating new release everytime by [@&truecharts#8203;1337-server](https://togithub.com/1337-server) in [automatic-ripping-machine/automatic-ripping-machine#917 - Bump docker/setup-buildx-action from 2.9.1 to 2.10.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#920 - Bump actions/checkout from 3 to 4 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#932 - Ntfy and Bash for notifications by [@&truecharts#8203;newhinton](https://togithub.com/newhinton) in [automatic-ripping-machine/automatic-ripping-machine#930 - Fix handling of the abcde.conf file for docker by [@&truecharts#8203;martini1992](https://togithub.com/martini1992) in [automatic-ripping-machine/automatic-ripping-machine#938 - Add option to disable ejection on an unidentified disc ([#&truecharts#8203;779](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/779)) by [@&truecharts#8203;martini1992](https://togithub.com/martini1992) in [automatic-ripping-machine/automatic-ripping-machine#937 - Bump docker/build-push-action from 4 to 5 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#940 - Bump docker/metadata-action from 4.6.0 to 5.0.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#943 - Bump docker/setup-buildx-action from 2.10.0 to 3.0.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#941 - Bump docker/login-action from 2.2.0 to 3.0.0 by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#942 - Add k10temp support for more AMD platforms by [@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#958 - Fix transcode free space by [@&truecharts#8203;rgooler](https://togithub.com/rgooler) in [automatic-ripping-machine/automatic-ripping-machine#954 - Add Apprise test button by [@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#963 - Resolved issue with dev tools by [@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in [automatic-ripping-machine/automatic-ripping-machine#966 - Use Waitress as WSGI Server by [@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#964 - Bump arm-dependencies from `0d608cb` to `c3b0745` by [@&truecharts#8203;dependabot](https://togithub.com/dependabot) in [automatic-ripping-machine/automatic-ripping-machine#970 - Parse bluray label for OMDB search by [@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in [automatic-ripping-machine/automatic-ripping-machine#962 - Models Refactor by [@&truecharts#8203;shitwolfymakes](https://togithub.com/shitwolfymakes) in [automatic-ripping-machine/automatic-ripping-machine#977 #### New Contributors - [@&truecharts#8203;martini1992](https://togithub.com/martini1992) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#938 - [@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#958 - [@&truecharts#8203;rgooler](https://togithub.com/rgooler) made their first contribution in [automatic-ripping-machine/automatic-ripping-machine#954 **Full Changelog**: automatic-ripping-machine/automatic-ripping-machine@2.6.60...2.6.67 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables the automatic ejecting of an unidentified disc, to prevent immediate ejection of discs on certain (Pioneer slim) drives.
Fixes #779
Type of change
Please delete options that are not relevant.
(Could be seen as both)
How Has This Been Tested?
Several people on the ticket including me have tested removing the offending line (including me).
I have added extra code to make this configurable, with the default behaviour being the original behaviour.
Checklist: