Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add k10temp support for more AMD platforms #958

Merged

Conversation

anthonylavado
Copy link
Contributor

@anthonylavado anthonylavado commented Oct 13, 2023

Description

An extension of #844, which was a fix for #754.

While adding the I/O expansion chips for the other platforms is useful, k10temp is a kernel driver that automatically handles getting temperature for AMD CPUs. In the event that the other I/O chip readings are preferred, I have placed this addition at the bottom of the list.

A list of platforms supported is here: https://docs.kernel.org/hwmon/k10temp.html

Generally, the kernel driver covers AMD Family 10h (Opteron, 2007-2012) through 19h (Zen 4, Sept 2022 - current).

Fixes #754

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Docker

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested that my fix is effective or that my feature works

Changelog:

Include the details of changes made here

  • ServerUtil - Add reading k10temp for AMD Platform CPU Temperatures

Logs

N/A

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@microtechno9000
Copy link
Collaborator

Looks good
Could you post the output from psutils for your processor
It will help if we need to make changes later on to know what the output looks like

Also there is a quality check that failed, please resolve that and then recommit.

@anthonylavado
Copy link
Contributor Author

anthonylavado commented Oct 13, 2023

From psutil:

{
'nvme':
[shwtemp(label='Composite', current=39.85, high=83.85, critical=87.85)],
'k10temp':
[shwtemp(label='Tctl', current=32.875, high=None, critical=None), shwtemp(label='Tccd1', current=32.75, high=None, critical=None)]
} 

The quality check that failed is called greetings and I'm not quite sure what it does. I see that all other checks (including formatting) passed, and I made sure to run pycodestyle before committing.

@microtechno9000
Copy link
Collaborator

looks like the script has failed on the github side

@microtechno9000 microtechno9000 merged commit 8256e42 into automatic-ripping-machine:main Oct 13, 2023
10 of 11 checks passed
@anthonylavado anthonylavado deleted the k10temp branch October 14, 2023 00:07
truecharts-admin added a commit to truecharts/charts that referenced this pull request Jan 3, 2024
…-ripping-machine to v2.6.67@8310b23 by renovate (#16800)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine)
| patch | `2.6.60` -> `2.6.67` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>automatic-ripping-machine/automatic-ripping-machine
(automaticrippingmachine/automatic-ripping-machine)</summary>

###
[`v2.6.67`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.67)

[Compare
Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.60...2.6.67)

#### What's Changed

- Fix for 914 - automatic build/release creating new release everytime
by [@&#8203;1337-server](https://togithub.com/1337-server) in
[automatic-ripping-machine/automatic-ripping-machine#917
- Bump docker/setup-buildx-action from 2.9.1 to 2.10.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#920
- Bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#932
- Ntfy and Bash for notifications by
[@&#8203;newhinton](https://togithub.com/newhinton) in
[automatic-ripping-machine/automatic-ripping-machine#930
- Fix handling of the abcde.conf file for docker by
[@&#8203;martini1992](https://togithub.com/martini1992) in
[automatic-ripping-machine/automatic-ripping-machine#938
- Add option to disable ejection on an unidentified disc
([#&#8203;779](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/779))
by [@&#8203;martini1992](https://togithub.com/martini1992) in
[automatic-ripping-machine/automatic-ripping-machine#937
- Bump docker/build-push-action from 4 to 5 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#940
- Bump docker/metadata-action from 4.6.0 to 5.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#943
- Bump docker/setup-buildx-action from 2.10.0 to 3.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#941
- Bump docker/login-action from 2.2.0 to 3.0.0 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#942
- Add k10temp support for more AMD platforms by
[@&#8203;anthonylavado](https://togithub.com/anthonylavado) in
[automatic-ripping-machine/automatic-ripping-machine#958
- Fix transcode free space by
[@&#8203;rgooler](https://togithub.com/rgooler) in
[automatic-ripping-machine/automatic-ripping-machine#954
- Add Apprise test button by
[@&#8203;anthonylavado](https://togithub.com/anthonylavado) in
[automatic-ripping-machine/automatic-ripping-machine#963
- Resolved issue with dev tools by
[@&#8203;microtechno9000](https://togithub.com/microtechno9000) in
[automatic-ripping-machine/automatic-ripping-machine#966
- Use Waitress as WSGI Server by
[@&#8203;anthonylavado](https://togithub.com/anthonylavado) in
[automatic-ripping-machine/automatic-ripping-machine#964
- Bump arm-dependencies from `0d608cb` to `c3b0745` by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#970
- Parse bluray label for OMDB search by
[@&#8203;anthonylavado](https://togithub.com/anthonylavado) in
[automatic-ripping-machine/automatic-ripping-machine#962
- Models Refactor by
[@&#8203;shitwolfymakes](https://togithub.com/shitwolfymakes) in
[automatic-ripping-machine/automatic-ripping-machine#977

#### New Contributors

- [@&#8203;martini1992](https://togithub.com/martini1992) made their
first contribution in
[automatic-ripping-machine/automatic-ripping-machine#938
- [@&#8203;anthonylavado](https://togithub.com/anthonylavado) made their
first contribution in
[automatic-ripping-machine/automatic-ripping-machine#958
- [@&#8203;rgooler](https://togithub.com/rgooler) made their first
contribution in
[automatic-ripping-machine/automatic-ripping-machine#954

**Full Changelog**:
automatic-ripping-machine/automatic-ripping-machine@2.6.60...2.6.67

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
GabrielBarzen pushed a commit to GabrielBarzen/charts that referenced this pull request Feb 2, 2024
…-ripping-machine to v2.6.67@8310b23 by renovate (truecharts#16800)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[automaticrippingmachine/automatic-ripping-machine](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine)
| patch | `2.6.60` -> `2.6.67` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>automatic-ripping-machine/automatic-ripping-machine
(automaticrippingmachine/automatic-ripping-machine)</summary>

###
[`v2.6.67`](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/releases/tag/2.6.67)

[Compare
Source](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/compare/2.6.60...2.6.67)

#### What's Changed

- Fix for 914 - automatic build/release creating new release everytime
by [@&truecharts#8203;1337-server](https://togithub.com/1337-server) in
[automatic-ripping-machine/automatic-ripping-machine#917
- Bump docker/setup-buildx-action from 2.9.1 to 2.10.0 by
[@&truecharts#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#920
- Bump actions/checkout from 3 to 4 by
[@&truecharts#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#932
- Ntfy and Bash for notifications by
[@&truecharts#8203;newhinton](https://togithub.com/newhinton) in
[automatic-ripping-machine/automatic-ripping-machine#930
- Fix handling of the abcde.conf file for docker by
[@&truecharts#8203;martini1992](https://togithub.com/martini1992) in
[automatic-ripping-machine/automatic-ripping-machine#938
- Add option to disable ejection on an unidentified disc
([#&truecharts#8203;779](https://togithub.com/automatic-ripping-machine/automatic-ripping-machine/issues/779))
by [@&truecharts#8203;martini1992](https://togithub.com/martini1992) in
[automatic-ripping-machine/automatic-ripping-machine#937
- Bump docker/build-push-action from 4 to 5 by
[@&truecharts#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#940
- Bump docker/metadata-action from 4.6.0 to 5.0.0 by
[@&truecharts#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#943
- Bump docker/setup-buildx-action from 2.10.0 to 3.0.0 by
[@&truecharts#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#941
- Bump docker/login-action from 2.2.0 to 3.0.0 by
[@&truecharts#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#942
- Add k10temp support for more AMD platforms by
[@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in
[automatic-ripping-machine/automatic-ripping-machine#958
- Fix transcode free space by
[@&truecharts#8203;rgooler](https://togithub.com/rgooler) in
[automatic-ripping-machine/automatic-ripping-machine#954
- Add Apprise test button by
[@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in
[automatic-ripping-machine/automatic-ripping-machine#963
- Resolved issue with dev tools by
[@&truecharts#8203;microtechno9000](https://togithub.com/microtechno9000) in
[automatic-ripping-machine/automatic-ripping-machine#966
- Use Waitress as WSGI Server by
[@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in
[automatic-ripping-machine/automatic-ripping-machine#964
- Bump arm-dependencies from `0d608cb` to `c3b0745` by
[@&truecharts#8203;dependabot](https://togithub.com/dependabot) in
[automatic-ripping-machine/automatic-ripping-machine#970
- Parse bluray label for OMDB search by
[@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) in
[automatic-ripping-machine/automatic-ripping-machine#962
- Models Refactor by
[@&truecharts#8203;shitwolfymakes](https://togithub.com/shitwolfymakes) in
[automatic-ripping-machine/automatic-ripping-machine#977

#### New Contributors

- [@&truecharts#8203;martini1992](https://togithub.com/martini1992) made their
first contribution in
[automatic-ripping-machine/automatic-ripping-machine#938
- [@&truecharts#8203;anthonylavado](https://togithub.com/anthonylavado) made their
first contribution in
[automatic-ripping-machine/automatic-ripping-machine#958
- [@&truecharts#8203;rgooler](https://togithub.com/rgooler) made their first
contribution in
[automatic-ripping-machine/automatic-ripping-machine#954

**Full Changelog**:
automatic-ripping-machine/automatic-ripping-machine@2.6.60...2.6.67

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMTYuMCIsInVwZGF0ZWRJblZlciI6IjM3LjExNy4xIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐋 CPU temp wont show correct number
2 participants