Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite useAuthClients with RQ #1793

Merged
merged 1 commit into from
Apr 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions packages/backend/src/graphql/queries/get-app-auth-clients.ee.js

This file was deleted.

2 changes: 0 additions & 2 deletions packages/backend/src/graphql/query-resolvers.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import getApp from './queries/get-app.js';
import getAppAuthClient from './queries/get-app-auth-client.ee.js';
import getAppAuthClients from './queries/get-app-auth-clients.ee.js';
import getBillingAndUsage from './queries/get-billing-and-usage.ee.js';
import getConnectedApps from './queries/get-connected-apps.js';
import getDynamicData from './queries/get-dynamic-data.js';
Expand All @@ -11,7 +10,6 @@ import testConnection from './queries/test-connection.js';
const queryResolvers = {
getApp,
getAppAuthClient,
getAppAuthClients,
getBillingAndUsage,
getConnectedApps,
getDynamicData,
Expand Down
1 change: 0 additions & 1 deletion packages/backend/src/graphql/schema.graphql
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
type Query {
getApp(key: String!): App
getAppAuthClient(id: String!): AppAuthClient
getAppAuthClients(appKey: String!, active: Boolean): [AppAuthClient]
getConnectedApps(name: String): [App]
testConnection(id: String!): Connection
getFlow(id: String!): Flow
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,27 @@ import Chip from '@mui/material/Chip';
import Button from '@mui/material/Button';
import * as URLS from 'config/urls';
import useFormatMessage from 'hooks/useFormatMessage';
import useAppAuthClients from 'hooks/useAppAuthClients.ee';
import useAdminAppAuthClients from 'hooks/useAdminAppAuthClients';
import NoResultFound from 'components/NoResultFound';

function AdminApplicationAuthClients(props) {
const { appKey } = props;
const formatMessage = useFormatMessage();
const { appAuthClients, loading } = useAppAuthClients({ appKey });
if (loading)
const { data: appAuthClients, isLoading } = useAdminAppAuthClients(appKey);

if (isLoading)
return <CircularProgress sx={{ display: 'block', margin: '20px auto' }} />;
if (!appAuthClients?.length) {

if (!appAuthClients?.data.length) {
return (
<NoResultFound
to={URLS.ADMIN_APP_AUTH_CLIENTS_CREATE(appKey)}
text={formatMessage('adminAppsAuthClients.noAuthClients')}
/>
);
}
const sortedAuthClients = appAuthClients.slice().sort((a, b) => {

const sortedAuthClients = appAuthClients.data.slice().sort((a, b) => {
if (a.id < b.id) {
return -1;
}
Expand All @@ -36,6 +39,7 @@ function AdminApplicationAuthClients(props) {
}
return 0;
});

return (
<div>
{sortedAuthClients.map((client) => (
Expand Down
18 changes: 11 additions & 7 deletions packages/web/src/components/AppAuthClientsDialog/index.ee.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,33 @@ import ListItem from '@mui/material/ListItem';
import ListItemButton from '@mui/material/ListItemButton';
import ListItemText from '@mui/material/ListItemText';
import * as React from 'react';
import useAppAuthClients from 'hooks/useAppAuthClients.ee';
import useAppAuthClients from 'hooks/useAppAuthClients';
import useFormatMessage from 'hooks/useFormatMessage';

function AppAuthClientsDialog(props) {
const { appKey, onClientClick, onClose } = props;
const { appAuthClients } = useAppAuthClients({ appKey, active: true });
const { data: appAuthClients } = useAppAuthClients(appKey);

const formatMessage = useFormatMessage();

React.useEffect(
function autoAuthenticateSingleClient() {
if (appAuthClients?.length === 1) {
onClientClick(appAuthClients[0].id);
if (appAuthClients?.data.length === 1) {
onClientClick(appAuthClients.data[0].id);
}
},
[appAuthClients],
[appAuthClients?.data],
);
if (!appAuthClients?.length || appAuthClients?.length === 1)

if (!appAuthClients?.data.length || appAuthClients?.data.length === 1)
return <React.Fragment />;

return (
<Dialog onClose={onClose} open={true}>
<DialogTitle>{formatMessage('appAuthClientsDialog.title')}</DialogTitle>

<List sx={{ pt: 0 }}>
{appAuthClients.map((appAuthClient) => (
{appAuthClients.data.map((appAuthClient) => (
<ListItem disableGutters key={appAuthClient.id}>
<ListItemButton onClick={() => onClientClick(appAuthClient.id)}>
<ListItemText primary={appAuthClient.name} />
Expand Down
11 changes: 0 additions & 11 deletions packages/web/src/graphql/queries/get-app-auth-clients.ee.js

This file was deleted.

17 changes: 17 additions & 0 deletions packages/web/src/hooks/useAdminAppAuthClients.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { useQuery } from '@tanstack/react-query';
import api from 'helpers/api';

export default function useAdminAppAuthClient(appKey) {
const query = useQuery({
queryKey: ['admin', 'apps', appKey, 'auth-clients'],
queryFn: async ({ signal }) => {
const { data } = await api.get(`/v1/admin/apps/${appKey}/auth-clients`, {
signal,
});
return data;
},
enabled: !!appKey,
});

return query;
}
25 changes: 0 additions & 25 deletions packages/web/src/hooks/useAppAuthClients.ee.js

This file was deleted.

17 changes: 17 additions & 0 deletions packages/web/src/hooks/useAppAuthClients.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { useQuery } from '@tanstack/react-query';
import api from 'helpers/api';

export default function useAppAuthClients(appKey) {
const query = useQuery({
queryKey: ['apps', appKey, 'auth-clients'],
queryFn: async ({ signal }) => {
const { data } = await api.get(`/v1/apps/${appKey}/auth-clients`, {
signal,
});
return data;
},
enabled: !!appKey,
});

return query;
}
Loading