Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Cache: check that plugin links is an array before adding Settings link #37600

Closed
donnchawp opened this issue May 28, 2024 · 0 comments · Fixed by #37604
Closed

Super Cache: check that plugin links is an array before adding Settings link #37600

donnchawp opened this issue May 28, 2024 · 0 comments · Fixed by #37604
Labels
[Plugin] Super Cache A fast caching plugin for WordPress. [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended

Comments

@donnchawp
Copy link
Contributor

This is a very odd one, as it was only ever reported once here. The user reported an error in the code that adds the Settings link to the Plugins page entry for this plugin.
As this is a non critical part of the plugin, I'm tempted to remove the code entirely because when the plugin is installed first, an admin notice is displayed prompting the user to go to the settings page.
Another fix will be a small check on the $links array to make sure it is an array in the wp_cache_plugin_actions function in wp-cache.php

@donnchawp donnchawp added [Plugin] Super Cache A fast caching plugin for WordPress. [Type] Bug When a feature is broken and / or not performing as intended labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Super Cache A fast caching plugin for WordPress. [Pri] Normal Triaged [Type] Bug When a feature is broken and / or not performing as intended
Development

Successfully merging a pull request may close this issue.

2 participants