Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added binary search to doc decode for big speedup #153

Merged
merged 1 commit into from
May 29, 2021
Merged

added binary search to doc decode for big speedup #153

merged 1 commit into from
May 29, 2021

Conversation

orionz
Copy link
Collaborator

@orionz orionz commented May 27, 2021

found a place with in document loads that was bottlenecking - sped it up with a binary search. Also did some code cleanup for easier reading.

jeffa5
jeffa5 reviewed May 27, 2021
View reviewed changes
Copy link
Collaborator

@jeffa5 jeffa5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic looks good, one thing I'm thinking about is if this now relies on changes being encoded in causal order? I'm not sure if that is a current requirement of the binary format or not - haven't really seen docs for it.

automerge-backend/src/change.rs Show resolved Hide resolved
@orionz orionz merged commit d8a56d9 into main May 29, 2021
@orionz orionz deleted the faster_loads branch June 16, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffa5 jeffa5 jeffa5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orionz @jeffa5