Update for release #335
Merged
Update for release #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #335 +/- ##
===============================================
- Coverage 82.18% 82.13% -0.05%
===============================================
Files 153 153
Lines 8812 8812
Branches 1341 1341
===============================================
- Hits 7242 7238 -4
- Misses 1105 1107 +2
- Partials 465 467 +2
Continue to review full report at Codecov.
|
| @@ -23,7 +23,7 @@ | |||
| name="autoPyTorch", | |||
| version="0.1.0", | |||
| author="AutoML Freiburg", | |||
| author_email="zimmerl@informatik.uni-freiburg.de", | |||
| author_email="eddiebergmanhs@gmail.com", | |||
There was a problem hiding this comment.
Shouldn't it be a freiburg email address?
There was a problem hiding this comment.
I asked for his email address for this purpose and that's what he gave me. I think its fine.
Comment on lines
246
to
247
| do not save the predictions for the optimization/validation set, | ||
| which would later on be used to build an ensemble. |
There was a problem hiding this comment.
Suggested change
| do not save the predictions for the optimization/validation set, | |
| which would later on be used to build an ensemble. | |
| which would later on be used to build an ensemble. | |
| Note that SMAC optimizes a metric evaluated on the optimization (i.e. validation) set. |
autoPyTorch/api/base_task.py
Outdated
|
|
||
| + `y_optimization`: | ||
| do not save the predictions for the optimization/validation set, | ||
| which would later on be used to build an ensemble. |
There was a problem hiding this comment.
Suggested change
| which would later on be used to build an ensemble. | |
| which would later on be used to build an ensemble. | |
| Note that SMAC optimizes a metric evaluated on the optimization (i.e. validation) set. |
README.md
Outdated
Comment on lines
58
to
59
| X_test=X_test.copy(), | ||
| y_test=y_test.copy(), |
There was a problem hiding this comment.
Do we still need copy()?
There was a problem hiding this comment.
yeah we don't, I'll remove it
ravinkohli
force-pushed
the
fixes_for_release
branch
from
a912db7
to
c8f0db9
Compare
|
Hello, I think we can merge this PR. |
ravinkohli
added a commit
that referenced
this pull request
Nov 23, 2021
* [enhance] Increase the coverage (#336) * [feat] Support statistics print by adding results manager object (#334) * [feat] Support statistics print by adding results manager object * [refactor] Make SearchResults extract run_history at __init__ Since the search results should not be kept in eternally, I made this class to take run_history in __init__ so that we can implicitly call extraction inside. From this change, the call of extraction from outside is not recommended. However, you can still call it from outside and to prevent mixup of the environment, self.clear() will be called. * [fix] Separate those changes into PR#336 * [fix] Fix so that test_loss includes all the metrics * [enhance] Strengthen the test for sprint and SearchResults * [fix] Fix an issue in documentation * [enhance] Increase the coverage * [refactor] Separate the test for results_manager to organize the structure * [test] Add the test for get_incumbent_Result * [test] Remove the previous test_get_incumbent and see the coverage * [fix] [test] Fix reversion of metric and strengthen the test cases * [fix] Fix flake8 issues and increase coverage * [fix] Address Ravin's comments * [enhance] Increase the coverage * [fix] Fix a flake8 issu * Update for release (#335) * Create release workflow and CITATION.cff and update README, setup.py * fix bug in pypy token * fix documentation formatting * TODO for docker image * accept suggestions from shuhei * add further options for disable_file_output documentation * remove from release.yml * [feat] Add templates for issue and PR with the Ravin's suggestions (#136) * [doc] Add the workflow of the Auto-Pytorch (#285) * [doc] Add workflow of the AutoPytorch * [doc] Address Ravin's comment * [FIX] Silence catboost (#338) * set verbose=False in catboost * fix flake * change worst possible result of r2 (#340) * Update README.md with link for master branch * [FIX formatting in docs (#342) * fix formatting in docs * Update examples/40_advanced/example_resampling_strategy.py * Update README.md, remove cat requirements.txt Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes necessary for release v0.1.0.
setup.py.