Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX formatting in docs #342

Merged
merged 2 commits into from
Nov 22, 2021
Merged

[FIX formatting in docs #342

merged 2 commits into from
Nov 22, 2021

Conversation

ravinkohli
Copy link
Contributor

@ravinkohli ravinkohli commented Nov 22, 2021

This PR fixes the following

  1. in example_parellel_n_jobs.py: the title of the file as it appears on the generated examples page
  2. example_custom_configuration_space.py: formatting of the list.
  3. In example_resampling_strategy.py: Made Sections for various strategies and subsections for the code headings.

Copy link
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I put minor comments

Comment on lines +84 to +87
X_train=X_train.copy(),
y_train=y_train.copy(),
X_test=X_test.copy(),
y_test=y_test.copy(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.copy()

Comment on lines +119 to +120
X_test=X_test.copy(),
y_test=y_test.copy(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.copy()

@@ -51,7 +54,7 @@

############################################################################
# Search for an ensemble of machine learning algorithms
# =====================================================
# -----------------------------------------------------
api.search(
X_train=X_train,
y_train=y_train,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.copy()

api = TabularClassificationTask(
resampling_strategy=CrossValTypes.k_fold_cross_validation,
resampling_strategy_args={'num_splits': 3}
)

############################################################################
# Search for an ensemble of machine learning algorithms
# =====================================================
# ------------
api.search(
X_train=X_train,
y_train=y_train,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.copy()

@@ -124,7 +135,7 @@

############################################################################
# Search for an ensemble of machine learning algorithms
# =====================================================
# -----------------------------------------------------
api.search(
X_train=X_train,
y_train=y_train,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.copy()

Comment on lines +50 to +51
X_test=X_test.copy(),
y_test=y_test.copy(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.copy()

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #342 (51645e6) into development (f7e9cf8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #342   +/-   ##
============================================
  Coverage        82.20%   82.20%           
============================================
  Files              153      153           
  Lines             8812     8812           
  Branches          1341     1341           
============================================
  Hits              7244     7244           
- Misses            1103     1104    +1     
+ Partials           465      464    -1     
Impacted Files Coverage Δ
autoPyTorch/datasets/base_dataset.py 80.80% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7e9cf8...51645e6. Read the comment docs.

@ravinkohli ravinkohli merged commit 5b65244 into automl:development Nov 22, 2021
github-actions bot pushed a commit that referenced this pull request Nov 22, 2021
ravinkohli added a commit that referenced this pull request Nov 23, 2021
* [enhance] Increase the coverage (#336)

* [feat] Support statistics print by adding results manager object (#334)

* [feat] Support statistics print by adding results manager object

* [refactor] Make SearchResults extract run_history at __init__

Since the search results should not be kept in eternally,
I made this class to take run_history in __init__ so that
we can implicitly call extraction inside.
From this change, the call of extraction from outside is not recommended.
However, you can still call it from outside and to prevent mixup of
the environment, self.clear() will be called.

* [fix] Separate those changes into PR#336

* [fix] Fix so that test_loss includes all the metrics

* [enhance] Strengthen the test for sprint and SearchResults

* [fix] Fix an issue in documentation

* [enhance] Increase the coverage

* [refactor] Separate the test for results_manager to organize the structure

* [test] Add the test for get_incumbent_Result

* [test] Remove the previous test_get_incumbent and see the coverage

* [fix] [test] Fix reversion of metric and strengthen the test cases

* [fix] Fix flake8 issues and increase coverage

* [fix] Address Ravin's comments

* [enhance] Increase the coverage

* [fix] Fix a flake8 issu

* Update for release (#335)

* Create release workflow and CITATION.cff  and update README, setup.py

* fix bug in pypy token

* fix documentation formatting

* TODO for docker image

* accept suggestions from shuhei

* add further options for disable_file_output documentation

* remove  from release.yml

* [feat] Add templates for issue and PR with the Ravin's suggestions (#136)

* [doc] Add the workflow of the Auto-Pytorch (#285)

* [doc] Add workflow of the AutoPytorch

* [doc] Address Ravin's comment

* [FIX] Silence catboost (#338)

* set verbose=False in catboost

* fix flake

* change worst possible result of r2 (#340)

* Update README.md with link for master branch

* [FIX formatting in docs (#342)

* fix formatting in docs

* Update examples/40_advanced/example_resampling_strategy.py

* Update README.md, remove cat requirements.txt

Co-authored-by: nabenabe0928 <47781922+nabenabe0928@users.noreply.github.com>
ravinkohli added a commit that referenced this pull request Dec 8, 2021
* fix formatting in docs

* Update examples/40_advanced/example_resampling_strategy.py

Update README.md, remove cat requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants