Fixes equality with ordering of hyperparameters (#212)

automl · Dec 15, 2021 · 4d69931 · 4d69931
1 parent 9856e62
commit 4d69931
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/ConfigSpace/hyperparameters.pyx b/ConfigSpace/hyperparameters.pyx
@@ -1506,7 +1506,7 @@ cdef class CategoricalHyperparameter(Hyperparameter):
 
         return (
             self.name == other.name and
-            self.choices == other.choices
+            set(self.choices) == set(other.choices)
         )
 
     def __hash__(self):

diff --git a/test/test_hyperparameters.py b/test/test_hyperparameters.py
@@ -577,6 +577,11 @@ def test_categorical(self):
         self.assertNotEqual(f1, f2)
         self.assertNotEqual(f1, "UniformFloat")
 
+        # Test that order of categoricals does not matter
+        f7 = CategoricalHyperparameter("param", ["a", "b"])
+        f7_ = CategoricalHyperparameter("param", ["b", "a"])
+        assert f7 == f7_
+
         # test that meta-data is stored correctly
         f_meta = CategoricalHyperparameter("param", ["a", "b"], default_value="a",
                                            meta=dict(self.meta_data))