Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] Move from richcmp to __eq__() #182

Merged
merged 2 commits into from
Apr 22, 2021

Conversation

franchuterivera
Copy link
Contributor

Enables the use of eq() as it is now supported in cython.

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #182 (98740d5) into master (772665a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #182   +/-   ##
=======================================
  Coverage   68.20%   68.20%           
=======================================
  Files          18       18           
  Lines        1774     1774           
=======================================
  Hits         1210     1210           
  Misses        564      564           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 772665a...98740d5. Read the comment docs.

ConfigSpace/conditions.pyx Show resolved Hide resolved
ConfigSpace/conditions.pyx Outdated Show resolved Hide resolved
ConfigSpace/conditions.pyx Outdated Show resolved Hide resolved
ConfigSpace/forbidden.pyx Outdated Show resolved Hide resolved
@mfeurer
Copy link
Contributor

mfeurer commented Apr 21, 2021

Hey, do you have any idea why the distcheck fails?

@franchuterivera
Copy link
Contributor Author

Sadly I do not known, as in my laptop (and previous check) that was not a problem. Can you please rerun the check (maybe github actions issue)? I do not think I have permission to do so.

@mfeurer
Copy link
Contributor

mfeurer commented Apr 22, 2021

Alright, today the restarting worked.

@mfeurer mfeurer merged commit b2fe51e into automl:master Apr 22, 2021
github-actions bot pushed a commit to Kerilk/ConfigSpace that referenced this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants