Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double github action test triggers #213

Merged
merged 10 commits into from
Jan 26, 2022
Merged

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Dec 15, 2021

  • Adds windows and osx to the pytest workflows but have them disabled.
  • Removes double trigger of tests with each push to a PR
  • Add manual trigger workflow_dispatch
  • Make the file a bit cleaner, removing unneeded code

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #213 (269cb9a) into master (61d7259) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 269cb9a differs from pull request most recent head 41e2688. Consider uploading reports for the commit 41e2688 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
- Coverage   67.15%   67.11%   -0.05%     
==========================================
  Files          17       17              
  Lines        1629     1627       -2     
==========================================
- Hits         1094     1092       -2     
  Misses        535      535              
Impacted Files Coverage Δ
ConfigSpace/nx/classes/graph.py 23.66% <0.00%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61d7259...41e2688. Read the comment docs.

@eddiebergman
Copy link
Contributor Author

It appears unit tests for windows will require writing cmdline things, I'm not too sure or familiar with this honestly

@eddiebergman
Copy link
Contributor Author

Also appears the macos and conda don't play nicely as we have it, giving user permission errors.

@eddiebergman eddiebergman changed the title Added windows and osx to test workflow Fix double github action test triggers Dec 15, 2021
@mfeurer mfeurer closed this Jan 26, 2022
@mfeurer mfeurer reopened this Jan 26, 2022
@eddiebergman eddiebergman force-pushed the add_windos_and_osx_to_unittests branch from 269cb9a to 41e2688 Compare January 26, 2022 13:37
@mfeurer mfeurer merged commit c67b347 into master Jan 26, 2022
@mfeurer mfeurer deleted the add_windos_and_osx_to_unittests branch January 26, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants