-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair unittest and test coverage pipeline #37
Conversation
…ile cannot be read
…ent os Remove conda and dist tests from template, since they are not crucial for this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also, write brief docstrings describing each unit test?
This would then become the template or guide for adding more unit tests.
Would be nice if all tests pass on this branch, before merging to dev. Alternatively, you could use the PR to only merge the functionalities that are working and ✅. |
Currently all Tests pass, the only non-passing actions are pre-commit and docs. I was planning to get these two running on separate branches so that the PRs don't get too large. Would you prefer that I fix them all on one branch? |
If it is not too troublesome, we could merge only the unit testing bit and leave these 2 out. |
I would prefer merging this and then creating a new branch with a new PR to fix the docs and styling actions. I don't think it will take too much time to fix these workflows and I think the time is well invested, since we will then have a solid pipeline for clean further developments. |
This PR adds coverage results to the unittests. An appropriate badge both for passing all tests and the test coverage are added to the README. Moreover the toy test file is deleted and a new file testing the budget exhaustion has been added.