Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over to AutoML common #1318

Merged
merged 29 commits into from
Dec 2, 2021
Merged

Port over to AutoML common #1318

merged 29 commits into from
Dec 2, 2021

Conversation

eddiebergman
Copy link
Contributor

@eddiebergman eddiebergman commented Nov 23, 2021

  • Adds the automl_common submodule and uses it's backend for proof of concept
  • Updates the MANIFEST.in file to not include the test files of automl_common
  • Adds section to installation about installing from source (now that it's not as straight forward with submodules)
  • Updates workflow files to install submodules correctly

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #1318 (0a40223) into development (6f13379) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1318      +/-   ##
===============================================
+ Coverage        88.01%   88.35%   +0.33%     
===============================================
  Files              140      140              
  Lines            11163    11617     +454     
===============================================
+ Hits              9825    10264     +439     
- Misses            1338     1353      +15     
Impacted Files Coverage Δ
autosklearn/automl.py 88.44% <100.00%> (+1.34%) ⬆️
autosklearn/ensemble_builder.py 85.82% <100.00%> (ø)
autosklearn/ensembles/singlebest_ensemble.py 96.29% <100.00%> (ø)
autosklearn/evaluation/__init__.py 85.53% <100.00%> (ø)
autosklearn/evaluation/abstract_evaluator.py 93.05% <100.00%> (ø)
autosklearn/evaluation/test_evaluator.py 93.93% <100.00%> (ø)
autosklearn/evaluation/train_evaluator.py 92.39% <100.00%> (ø)
...preprocessing/imputation/categorical_imputation.py 96.29% <0.00%> (-0.77%) ⬇️
setup.py 0.00% <0.00%> (ø)
...ning/optimizers/metalearn_optimizer/metalearner.py 96.34% <0.00%> (+0.23%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f13379...0a40223. Read the comment docs.

.gitmodules Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
MANIFEST.in Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
test/test_util/test_backend.py Show resolved Hide resolved
scripts/2015_nips_paper/run/score_ensemble.py Show resolved Hide resolved
doc/installation.rst Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more typos, then we're good to go :)

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@eddiebergman eddiebergman merged commit b90c228 into development Dec 2, 2021
@eddiebergman eddiebergman deleted the pr_backend_submodule branch December 2, 2021 14:12
github-actions bot pushed a commit that referenced this pull request Dec 2, 2021
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
eddiebergman added a commit that referenced this pull request Jan 25, 2022
* Add submodule

* Port to abstract_ensemble, backend from automl_common

* Updated workflow files

* Update imports

* Trigger actions

* Another import fix

* update import

* m

* Backend fixes

* Backend parameter update

* fixture fix for backend

* Fix tests

* readd old abstract ensemble for now

* flake8'd

* Added install from source to readme

* Moved installation w.r.t submodules to the docs

* Temporarily remove submodule

* Readded submodule

* Updated to use automl_common under autosklearn

* Updated MANIFEST

* Removed uneeded statements from MANIFEST

* Fixed import

* Fixed comment line in MANIFEST.in

* Added automl_common/setup.py to MANIFEST

* Added prefix to script

* Re-added removed title #

* Added note for submodule for CONTRIBUTING

* Made the submodule step a bit more clear for contributing.md

* CONTRIBUTING fixes
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
eddiebergman added a commit that referenced this pull request Aug 18, 2022
* Add submodule

* Port to abstract_ensemble, backend from automl_common

* Updated workflow files

* Update imports

* Trigger actions

* Another import fix

* update import

* m

* Backend fixes

* Backend parameter update

* fixture fix for backend

* Fix tests

* readd old abstract ensemble for now

* flake8'd

* Added install from source to readme

* Moved installation w.r.t submodules to the docs

* Temporarily remove submodule

* Readded submodule

* Updated to use automl_common under autosklearn

* Updated MANIFEST

* Removed uneeded statements from MANIFEST

* Fixed import

* Fixed comment line in MANIFEST.in

* Added automl_common/setup.py to MANIFEST

* Added prefix to script

* Re-added removed title #

* Added note for submodule for CONTRIBUTING

* Made the submodule step a bit more clear for contributing.md

* CONTRIBUTING fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants