Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt data interface change with L1 #23

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

Jason-Zhangxin-Chen
Copy link
Collaborator

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen commented Apr 2, 2024

To close autonity/autonity#812, it requires the oracle server side to be aligned with the new interface.
As oracle-client watches the on-chain prices for debug loggings, it have to use the success code to replaced the legacy status code of price from oracle contract with the PR of autonity/autonity#967.

Thus, this PR present the adapation with L1 of the data interface update in oracle contract, it also update the local E2E test framework to adapt with the latest protocols of Autonity client.

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen changed the title adapt data interface change with L1, e2e test framework integration w… adapt data interface change with L1 Apr 2, 2024
@vpiyush
Copy link
Contributor

vpiyush commented May 23, 2024

I have reviewed the priceStatus change part, But there seems to be other changes, which i couldn't get the context of. Could you add some info about it

@Jason-Zhangxin-Chen
Copy link
Collaborator Author

I have reviewed the priceStatus change part, But there seems to be other changes, which i couldn't get the context of. Could you add some info about it

I update the description of the PR to let you know the details.

@Jason-Zhangxin-Chen
Copy link
Collaborator Author

I have reviewed the priceStatus change part, But there seems to be other changes, which i couldn't get the context of. Could you add some info about it

The other changes were about the adaptation in the e2e test framework with the mini Autonity Network setups.

@Jason-Zhangxin-Chen Jason-Zhangxin-Chen merged commit 456c4dd into master May 31, 2024
4 checks passed
@Jason-Zhangxin-Chen
Copy link
Collaborator Author

Going to merge this PR since there is just a single status code update in the round data returned from L1 Autonity Oracle Contract, the other changes are about the e2e test framework update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching RoundData from Oracle Contract for an invalid symbol
2 participants