Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.0.6.3 to Master #384

Merged
merged 15 commits into from
Aug 16, 2019
Merged

v.0.6.3 to Master #384

merged 15 commits into from
Aug 16, 2019

Conversation

mikkokotila
Copy link
Contributor

See commit details for more information.

backward compatibility merge daily-dev << master
- cleaned up Scan() namespace
- added one example to docs
…ement

- `experiment_name` is now compulsory
- Addresses #207 and prepare for browser based "command center"
- Added 'trees' reduction strategy
- Added 'forrest' reduction strategy
- added `scan_utils.py` as a home for helper functions for /scan
- fixed tests to handle the new changes
This is used in one of the examples in docs, which is now also corrected.
- invoked through `reduction_method='gamify'`
- checks and updates a parameter map in the experiment folder each permutation
- if parameter value status is changed to 'inactive' in the .json locally, then reduction will be applied (all permutations with that value will be removed)
-  Related with this, check out http://github.com/autonomio/gamify ... an add-on for live monitoring of experiments and analysis of experiment results, with coming features for controlling the experiment as well
- Related with #343 it's now possible to avoid saving model weights in `scan_object`, which might be desirable for very long runs with very large networks, due to the memory cost of keeping the weights throughout the experiment.
- fixed a small bug in `AutoParams` where choosing `network=False` resulted in 'dense' to be split into characters
- `max_param_values` is now optional in `AutoScan` and instead created the issue to handle the underlying problem properly #367
- fixed all the tests accordingly to the change in `AutoScan` arguments
- improved PR template
- improved issue template
- created feature request template
- created bugs template

- Actually added the `Scan(...save_weights=False...)` (this slipped through the cracks last night)
- Added `Scan(...save_weights=False...)` to tests
- changed the deploy test so local folder does not end up with garbage
...and more small fixes on the templates.
- Also fixes #367 (setting 4 per paramater as the default for automatic mode)
This will be added to docs later, but for now bare in mind that in order to have some metric stored in Talos experiment log, you have to use talos.utils.TorchHistory and use it like so:

Before the epoch iteration loop starts:

`history = History() # NOTE: this is required by Talos`

Then for example:
```
    for epoch in range(params['epochs']):
        optimizer.zero_grad()
        out = model(x_train)
        loss = criterion(out, y_train)
        loss.backward()
        optimizer.step()

        print(out == out.data.max())

        history.append(loss) # NOTE: this is required by Talos
```

Also...

- fixed some issues in AutoModel
- added a couple of initializers to AutoParams
@pep8speaks
Copy link

Hello @mikkokotila! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 122:80: E501 line too long (80 > 79 characters)

Line 41:80: E501 line too long (86 > 79 characters)

Line 36:80: E501 line too long (96 > 79 characters)

Line 11:18: E231 missing whitespace after ':'
Line 20:1: E302 expected 2 blank lines, found 1
Line 26:80: E501 line too long (107 > 79 characters)
Line 38:80: E501 line too long (85 > 79 characters)
Line 39:53: E127 continuation line over-indented for visual indent
Line 40:53: E127 continuation line over-indented for visual indent
Line 40:80: E501 line too long (83 > 79 characters)
Line 41:53: E127 continuation line over-indented for visual indent
Line 42:53: E127 continuation line over-indented for visual indent
Line 43:53: E127 continuation line over-indented for visual indent
Line 54:1: E101 indentation contains mixed spaces and tabs
Line 54:1: W191 indentation contains tabs
Line 54:21: E128 continuation line under-indented for visual indent
Line 59:1: E101 indentation contains mixed spaces and tabs

Line 23:80: E501 line too long (137 > 79 characters)
Line 26:80: E501 line too long (118 > 79 characters)

@coveralls
Copy link

coveralls commented Aug 16, 2019

Pull Request Test Coverage Report for Build 561

  • 116 of 190 (61.05%) changed or added relevant lines in 19 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-3.5%) to 85.658%

Changes Missing Coverage Covered Lines Changed/Added Lines %
talos/autom8/autoparams.py 1 2 50.0%
talos/reducers/reduce_run.py 7 9 77.78%
talos/utils/experiment_log_callback.py 9 11 81.82%
talos/utils/torch_history.py 3 5 60.0%
talos/autom8/autoscan.py 3 6 50.0%
talos/scan/scan_round.py 10 15 66.67%
talos/reducers/GamifyMap.py 40 51 78.43%
talos/reducers/forrest.py 1 14 7.14%
talos/reducers/trees.py 1 16 6.25%
talos/templates/datasets.py 1 21 4.76%
Totals Coverage Status
Change from base Build 527: -3.5%
Covered Lines: 1308
Relevant Lines: 1527

💛 - Coveralls

@mikkokotila mikkokotila merged commit efb1c66 into master Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants