Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.6.4 to Dev #392

Merged
merged 7 commits into from
Sep 3, 2019
Merged

v0.6.4 to Dev #392

merged 7 commits into from
Sep 3, 2019

Conversation

mikkokotila
Copy link
Contributor

@mikkokotila mikkokotila commented Sep 3, 2019

You want to make a PR to Talos

Thanks so much :) First, please take a moment to carefully check through
the below items:

  • Changes have gone through actual use testing
  • Docs are updated where relevant
  • Code is PEP8
  • All local tests have passed (run ./test.sh in /talos)
  • Travis tests have passed
  • Open a pull request
  • PR is to daily-dev branch

JanPokorny and others added 6 commits June 30, 2019 13:23
- Implements a custom error if a non-supported optimizer is used with with lr_normalizer #292
- Fixed docs typo #379
@pep8speaks
Copy link

pep8speaks commented Sep 3, 2019

Hello @mikkokotila! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:80: E501 line too long (84 > 79 characters)

Comment last updated at 2019-09-03 11:48:26 UTC

@coveralls
Copy link

coveralls commented Sep 3, 2019

Pull Request Test Coverage Report for Build 583

  • 12 of 13 (92.31%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 85.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
talos/model/hidden_layers.py 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
talos/model/network_shape.py 1 96.43%
Totals Coverage Status
Change from base Build 577: -0.1%
Covered Lines: 1279
Relevant Lines: 1494

💛 - Coveralls

@mikkokotila mikkokotila merged commit 0871f7e into dev Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants