Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.0.6.4 to Master #396

Merged
merged 14 commits into from
Sep 14, 2019
Merged

v.0.6.4 to Master #396

merged 14 commits into from
Sep 14, 2019

Conversation

mikkokotila
Copy link
Contributor

You want to make a PR to Talos

Thanks so much :) First, please take a moment to carefully check through
the below items:

  • Changes have gone through actual use testing
  • Docs are updated where relevant
  • Code is PEP8
  • All local tests have passed (run ./test.sh in /talos)
  • Travis tests have passed

JanPokorny and others added 13 commits June 30, 2019 13:23
The docs for `Analyze` said `plot_bars` for `plot_kde` as well.
The docs for `Analyze` said `plot_bars` for `plot_kde` as well.
- Implements a custom error if a non-supported optimizer is used with with lr_normalizer #292
- Fixed docs typo #379
* Fix the required parameters discrepancy

* Fix hidden_layers complexity

* Make @pep8speaks stop crying

* Handles PRs #292 and #379

- Implements a custom error if a non-supported optimizer is used with with lr_normalizer #292
- Fixed docs typo #379

* Updated PR template
It's now possible to set the number of `resample_params` in AutoParams. Also fixed typical example docs.
@pep8speaks
Copy link

pep8speaks commented Sep 14, 2019

Hello @mikkokotila! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 27:80: E501 line too long (84 > 79 characters)

Comment last updated at 2019-09-14 14:05:56 UTC

@coveralls
Copy link

coveralls commented Sep 14, 2019

Pull Request Test Coverage Report for Build 592

  • 14 of 15 (93.33%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 85.619%

Changes Missing Coverage Covered Lines Changed/Added Lines %
talos/model/hidden_layers.py 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
talos/model/network_shape.py 1 96.43%
Totals Coverage Status
Change from base Build 573: -0.04%
Covered Lines: 1280
Relevant Lines: 1495

💛 - Coveralls

@mikkokotila mikkokotila merged commit 8945e09 into master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants