Dev >> Master for 0.2 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replaced type comparison with isinstance - more pepification
- split handling() into ParamGrid() and round_params() - round_params() uses the ParamGrid() object - deleted handling() NOTE: there are some things in Scan() that can be done cleaner in the sense of avoiding redundancy, but I'm leaving that for a full refactor of Scan().
- added a function that returns all possible standard metric names (and round_epochs) - fixed spear reducer from the case where just columns after the 7th are included, to where all columns but those in metric_names are included - fixed 'loss' to 'losses' in p3 in test_scan()
- made clearing tf session every round a parameter (False by default)
- refactored Scan() and the way how parameters and reducers are handled - added an example iris model to examples/ - renamed notebooks to examples
Works in cases where a reduction is used, and where it's not.
- scan is now in its own submodule/folder - reduction files are now following the new convention - major refactor of reduction procedures
- version marking now just in main __init__.py and setup.py - fixed correlation reduction algo to spearman (it seems rank order makes most sense here) - deleted redundant files - added pycharm specific things to .gitignore - changed version to 0.2.0
0.2.0 version preparation
It's not that much of an issue but this could of easily prevented by having some Git typo hook to decline push/merge requests with typo in it. (e.g., https://github.com/intgr/topy)
Fixed small typo
Pull Request Test Coverage Report for Build 152
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing is added since the review on dev branch.