Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial work #1

Closed
wants to merge 3 commits into from
Closed

Initial work #1

wants to merge 3 commits into from

Conversation

jasonpincin
Copy link
Contributor

Initial work for AP pattern skeletal directory structure.

README.md Outdated

1. Update PRJ_NAME in `Makefile` to be a meaningful name, lile `redis`...
2. Update `Dockerfile` to source from the correct base image, install the
correct dependencies, and launch ContainerPilot with the proper primary
Copy link

@tgross tgross Apr 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't do 80 col wrap for the READMEs

# setup environment file
if [ ! -f "_env" ]; then
echo '# Environment variables for backups to Manta' >> _env
echo 'MANTA_BUCKET= # an existing Manta bucket' >> _env
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have documentation around when a user will want to cut this section for Manta config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Does that belong here or in the document Wyatt's working on or both? Would it be better to omit this section from the skeleton in favor of the skeleton being universally applicable?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that belong here or in the document Wyatt's working on or both?

It can go in @geek's document but I think a comment here would help to flag it clearly.

Would it be better to omit this section from the skeleton in favor of the skeleton being universally applicable?

I'm not 100% sure, but my gut says to leave it in because it's annoyingly complicated and easier to remove than it is to add back in correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants