-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix curl command error in URLDownloader.prefetch_filename() #939
Conversation
Previously, combining '--head' and '--request GET' allowed curl to perform a GET request and stop after receiving the headers. This workaround was added to handle servers that return HTTP Forbidden or incorrect headers for a HEAD request. However, with the update to curl 8.6.0 on macOS 14.5, this combination results in an error ("curl: (8) Weird server reply").
openjdk8-binaries.download.recipe is used as an example of a recipe that was fixed by the addition of the GET. As of AutoPkg 2.7.2 and macOS 14.5, this recipe is now broken again.
Running the same recipe against the modified URLDownloader processor used in this PR shows that the recipe is working in macOS 14.5 despite the absence of the GET:
I found 41 recipes in the AutoPkg org that use |
This reverts #626 which was added due to #624.
Previously, combining
--head
and--request GET
allowed curl to perform a GET request and stop after receiving the headers. This workaround was added to handle servers that return HTTP Forbidden or incorrect headers for a HEAD request. However, with the update to curl 8.6.0 on macOS 14.5, this combination results in an error ("curl: (8) Weird server reply").